diff options
| author | Florian Weimer <fweimer@redhat.com> | 2017-08-14 11:44:24 +0200 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2017-08-14 15:08:48 +0200 |
| commit | 9fa7449b35244645acaa450046b37678f46fe0f1 (patch) | |
| tree | 83a87696a1e4ae4fad80f9167bb25e02c91dfe53 /ChangeLog | |
| parent | 73322d5ff6ad71c65f875095c4801771cff9ab2d (diff) | |
| download | glibc-9fa7449b35244645acaa450046b37678f46fe0f1.tar.gz glibc-9fa7449b35244645acaa450046b37678f46fe0f1.tar.xz glibc-9fa7449b35244645acaa450046b37678f46fe0f1.zip | |
_dl_fini: Remove internal_function attribute
Assembler code passes the address of _dl_fini to __libc_start_main, whose function pointer argument lacks the attribute. This means that calls could use the wrong ABI. Fortunately, for zero-parameter void-returning functions, internal_function does not change ABI on i386 (the only architecture which uses internal_function), so this inconsistency was harmless (which is why it had not been noticed so far).
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 7527943446..bf655ed0b4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2017-08-14 Florian Weimer <fweimer@redhat.com> + + * elf/dl-fini.c (_dl_fini): Remove internal_function + * sysdeps/generic/ldsodefs.h (_dl_fini): Likewise. + 2017-08-14 H.J. Lu <hongjiu.lu@intel.com> * sysdeps/x86/cpu-features.h (bit_cpu_BIT): New. |