about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2015-09-18 20:34:59 +0000
committerJoseph Myers <joseph@codesourcery.com>2015-09-18 20:34:59 +0000
commit94ced920a951bcab51f2ef955ccd2cc51668e6f3 (patch)
tree703e39203cb6fc889572c9feb9acc7db37b750f8 /ChangeLog
parent89faa0340ad399ead8104f8fb6b7fed81f7d939c (diff)
downloadglibc-94ced920a951bcab51f2ef955ccd2cc51668e6f3.tar.gz
glibc-94ced920a951bcab51f2ef955ccd2cc51668e6f3.tar.xz
glibc-94ced920a951bcab51f2ef955ccd2cc51668e6f3.zip
Avoid excess range in results from i386 scalb functions (bug 18981).
i386 scalb / scalbn / scalbln (and thus ldexp) functions for float and
double can return results with excess range (and consequently excess
precision for subnormal results).  As the results of these functions
are fully determined by reference to IEEE 754 operations, this is
unambiguously a bug, apart from the testsuite failures it causes.

This patch makes those functions store their results on the stack and
load them back to eliminate the excess range.  Double rounding is not
a problem, as the only cases where it could occur are when the result
overflows or underflows for extended precision, and then the
double-rounded results are the same as the single-rounded results.

The new macros will be used for more functions, more such macros
added, and existing code refactored to use such macros, in subsequent
patches.

Tested for x86.  Committed.

	[BZ #18981]
	* sysdeps/i386/fpu/i386-math-asm.h: New file.
	* sysdeps/i386/fpu/e_scalb.S: Include <i386-math-asm.h>.
	(__ieee754_scalb): Use DBL_NARROW_EVAL.
	* sysdeps/i386/fpu/e_scalbf.S: Include <i386-math-asm.h>.
	(__ieee754_scalbf): Use FLT_NARROW_EVAL.
	* sysdeps/i386/fpu/s_scalbn.S: Include <i386-math-asm.h>.
	(__scalbn): Use DBL_NARROW_EVAL.
	* sysdeps/i386/fpu/s_scalbnf.S: Include <i386-math-asm.h>.
	(__scalbnf): Use FLT_NARROW_EVAL.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog13
1 files changed, 13 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 67c837da5a..cafe59e3fb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2015-09-18  Joseph Myers  <joseph@codesourcery.com>
+
+	[BZ #18981]
+	* sysdeps/i386/fpu/i386-math-asm.h: New file.
+	* sysdeps/i386/fpu/e_scalb.S: Include <i386-math-asm.h>.
+	(__ieee754_scalb): Use DBL_NARROW_EVAL.
+	* sysdeps/i386/fpu/e_scalbf.S: Include <i386-math-asm.h>.
+	(__ieee754_scalbf): Use FLT_NARROW_EVAL.
+	* sysdeps/i386/fpu/s_scalbn.S: Include <i386-math-asm.h>.
+	(__scalbn): Use DBL_NARROW_EVAL.
+	* sysdeps/i386/fpu/s_scalbnf.S: Include <i386-math-asm.h>.
+	(__scalbnf): Use FLT_NARROW_EVAL.
+
 2015-09-18  Wilco Dijkstra  <wdijkstr@arm.com>
 
 	* math/w_tgamma.c (__ieee754_gamma_r): Use explicit sign check.