about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2018-06-25 18:56:42 +0200
committerFlorian Weimer <fweimer@redhat.com>2018-06-25 18:58:49 +0200
commit90d9d9ce2fbeef0f24a957efa83f5a78367a84d4 (patch)
tree05ebd40e8bb0e922dcedfabb37e1084b24de41b7 /ChangeLog
parent6b7b2abac75f969a86c537d64adf003378e24113 (diff)
downloadglibc-90d9d9ce2fbeef0f24a957efa83f5a78367a84d4.tar.gz
glibc-90d9d9ce2fbeef0f24a957efa83f5a78367a84d4.tar.xz
glibc-90d9d9ce2fbeef0f24a957efa83f5a78367a84d4.zip
getgrent_next_nss (compat-initgroups): Remove alloca fallback [BZ #18023]
If the caller-supplied buffer is not large enough, fall back directly
malloc.

The previous __libc_use_alloca check was incorrect because it did not
take into account that extend_alloca may fail to merge allocations, so
it would underestimate the stack space being used by roughly a factor
of two.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog6
1 files changed, 6 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 1cafbb1882..6241a6369a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,12 @@
 2018-06-25  Florian Weimer  <fweimer@redhat.com>
 
 	[BZ #18023]
+	* nss/nss_compat/compat-initgroups.c (getgrent_next_nss): Fall
+	back to malloc directly, without stack allocations.
+
+2018-06-25  Florian Weimer  <fweimer@redhat.com>
+
+	[BZ #18023]
 	* nscd/aicache.c (addhstaiX): Use struct scratch_buffer instead
 	of extend_alloca.