diff options
| author | Carlos O'Donell <carlos@redhat.com> | 2014-02-28 18:11:06 -0500 |
|---|---|---|
| committer | Carlos O'Donell <carlos@redhat.com> | 2014-02-28 18:15:10 -0500 |
| commit | 8e25d1e7721d8078d8925e325799740dd53a5801 (patch) | |
| tree | ce4e8b68baec0bccef1f22744995b769bcc4f535 /ChangeLog | |
| parent | 7b3551e3a8f7278e123757987570c72f1216acc2 (diff) | |
| download | glibc-8e25d1e7721d8078d8925e325799740dd53a5801.tar.gz glibc-8e25d1e7721d8078d8925e325799740dd53a5801.tar.xz glibc-8e25d1e7721d8078d8925e325799740dd53a5801.zip | |
Promote do_lookup_x:check_match to a full function.
While it may be argued that nested functions make the resulting code easier to read, or worse to read the following two bugs make it difficult to debug: Bug 8300 - no local symbol information within nested or nesting procedures https://sourceware.org/bugzilla/show_bug.cgi?id=8300 Bug 53927 - wrong value for DW_AT_static_link http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53927 Until these are fixed I've made check_match a full function. After they are fixed we can resume arguing about the merits of nested functions on readability and maintenance.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index a5b1de26d0..60d63dbf88 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2014-02-28 Carlos O'Donell <carlos@redhat.com> + + * elf/dl-lookup.c (check_match): New function. + (ELF_MACHINE_SYM_NO_MATCH): Adjust comment. + (do_lookup_x): Remove nested function check_match. Use non-nested + function check_match. + 2014-02-28 Roland McGrath <roland@hack.frob.com> * csu/Makefile (generated, before-compile): Use += rather than =. |