diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2019-02-18 22:33:29 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2019-02-18 22:33:29 +0000 |
| commit | 8c9289b64271639661e5dbe3c19c0badc9db9cfa (patch) | |
| tree | f523846a9aba437bc8682289591ee34793183300 /ChangeLog | |
| parent | 308e022fc46a944700ad5a41530f36aaa6cc7dae (diff) | |
| download | glibc-8c9289b64271639661e5dbe3c19c0badc9db9cfa.tar.gz glibc-8c9289b64271639661e5dbe3c19c0badc9db9cfa.tar.xz glibc-8c9289b64271639661e5dbe3c19c0badc9db9cfa.zip | |
Fix SPARC64 handling of R_SPARC_H34 (bug 24231).
Building glibc with -Wextra shows a -Wimplicit-fallthrough warning for SPARC64 that appears to be a real bug in glibc. The dynamic linker handling of R_SPARC_H34 falls through to that of R_SPARC_H44, which in the case of this code is nonsensical (it means the value computed for R_SPARC_H34 gets overwritten by one computed with the different logic for R_SPARC_H44). Thus, this patch adds the missing break there. Note: I do not have a testcase to demonstrate this bug. Tested with build-many-glibcs.py. [BZ #24231] * sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela): Add break after R_SPARC_H34 case.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 312ef3bd8f..de10cb598f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2019-02-18 Joseph Myers <joseph@codesourcery.com> + + [BZ #24231] + * sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela): Add break + after R_SPARC_H34 case. + 2019-02-18 Florian Weimer <fweimer@redhat.com> * resolv/compat-gethnamaddr.c (Dprintf): Remove definition. |