about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorGabriel F. T. Gomes <gabriel@inconstante.eti.br>2019-03-21 17:24:30 -0300
committerGabriel F. T. Gomes <gabriel@inconstante.eti.br>2019-03-21 17:53:03 -0300
commit5abcddd7949270998c6e8d99fdbbba821b664f8b (patch)
tree27501fa7879f5e6fef7b71ca7664e1fccb325d6f /ChangeLog
parentac64195ccd4f320659fd0058bc7524c6fd0b37b4 (diff)
downloadglibc-5abcddd7949270998c6e8d99fdbbba821b664f8b.tar.gz
glibc-5abcddd7949270998c6e8d99fdbbba821b664f8b.tar.xz
glibc-5abcddd7949270998c6e8d99fdbbba821b664f8b.zip
Fix parentheses error in iconvconfig.c and ld-collate.c [BZ #24372]
When -Werror=parentheses is in use, iconvconfig.c builds fail with:

  iconvconfig.c: In function ‘write_output’:
  iconvconfig.c:1084:34: error: suggest parentheses around ‘+’ inside ‘>>’ [-Werror=parentheses]
     hash_size = next_prime (nnames + nnames >> 1);
                             ~~~~~~~^~~~~~~~

This patch adds parentheses to the expression.  Not where suggested by
the compiler warning, but where it produces the expected result, i.e.:
where it has the effect of multiplying nnames by 1.5.

Likewise for elem_size in ld-collate.c.

Tested for powerpc64le.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog7
1 files changed, 7 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index ba9b6151ed..f0ebd06b36 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2019-03-05  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
+
+	[BZ #24372]
+	* iconv/iconvconfig.c (write_output): Add parentheses to get rid
+	of compiler warning.
+	* locale/programs/ld-collate.c (collate_output): Likewise.
+
 2019-03-21  DJ Delorie  <dj@redhat.com>
 
 	[BZ #24372]