about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorArjun Shankar <arjun@redhat.com>2018-09-25 15:13:15 +0200
committerArjun Shankar <arjun@redhat.com>2018-09-25 15:13:15 +0200
commit335a3b0a0d26313537eddfc26db14e33deecc433 (patch)
tree8c6ba407e589316f831254a826006337c1c1441f /ChangeLog
parent462d348caa16843594d8f23170ba7b635d2df220 (diff)
downloadglibc-335a3b0a0d26313537eddfc26db14e33deecc433.tar.gz
glibc-335a3b0a0d26313537eddfc26db14e33deecc433.tar.xz
glibc-335a3b0a0d26313537eddfc26db14e33deecc433.zip
Clean up iconv/gconv_int.h for unnecessary declarations
The variables __gconv_path_elem, __gconv_max_path_elem_len and function
__gconv_get_path declared in, as well as the type path_elem and macro
GCONV_NCHAR_GOAL defined in gconv_int.h are all used in only one iconv
compilation unit each. In addition, the extern declaration of the variable
__gconv_nmodules refers to a variable that does not exist any more.
Considering this, these symbols do not need to be exposed via a header file.

This patch removes the extern declarations from the header file and moves
the definitions to the compilation units where they are used.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog12
1 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 81e58df2c5..3a38e4504e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2018-09-25  Arjun Shankar  <arjun@redhat.com>
+
+	* iconv/gconv_int.h (__gconv_path_elem): Remove.
+	(__gconv_max_path_elem_len): Likewise.
+	(__gconv_nmodules): Likewise.
+	(__gconv_get_path): Likewise.
+	(path_elem): Move to ...
+	* iconv/gconv_conf.c: ... here.
+	(__gconv_get_path): Mark function static.
+	* iconv/gconv_int.h (GCONV_NCHAR_GOAL): Move to ...
+	* iconv/gconv_open.c: ... here.
+
 2018-09-24  Andreas Schwab  <schwab@suse.de>
 
 	* scripts/haveversions.awk: New file.