diff options
| author | Chris Metcalf <cmetcalf@ezchip.com> | 2015-05-26 20:29:56 -0400 |
|---|---|---|
| committer | Chris Metcalf <cmetcalf@ezchip.com> | 2015-05-26 20:29:56 -0400 |
| commit | 1827059925140a1f0c16faf23ee895ee72f84efc (patch) | |
| tree | a967ab57564bee0580e355ee705320e6709bded4 /ChangeLog | |
| parent | 4da82229f0ea9dd50e43f15705ee92d5d30c4158 (diff) | |
| download | glibc-1827059925140a1f0c16faf23ee895ee72f84efc.tar.gz glibc-1827059925140a1f0c16faf23ee895ee72f84efc.tar.xz glibc-1827059925140a1f0c16faf23ee895ee72f84efc.zip | |
tile: use better variable naming in INLINE_SYSCALL
At issue for INLINE_SYSCALL was that it used "err" and "val" as variable names in a #define, so that if it was used in a context where the "caller" was also using "err" or "val", and those variables were passed in to INLINE_SYSCALL, we would end up referencing the internal shadowed variables instead. For example, "char val" in check_may_shrink_heap() in sysdeps/unix/sysv/linux/malloc-sysdep.h was being shadowed by the syscall return "val" in INLINE_SYSCALL, causing the "char val" not to get updated at all, and may_shrink_heap ended up always false. A similar fix was made to INTERNAL_VSYSCALL_CALL.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 7fcd403700..4a38a05643 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2015-05-26 Chris Metcalf <cmetcalf@ezchip.com> + + * sysdeps/unix/sysv/linux/tile/sysdep.h (INLINE_SYSCALL): + Avoid using variables in #defines that might cause shadowing. + (INTERNAL_VSYSCALL_CALL): Likewise. + 2015-05-26 Roland McGrath <roland@hack.frob.com> * sysdeps/nacl/lll_timedlock_wait.c: New file. |