about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2016-02-18 22:54:07 +0000
committerJoseph Myers <joseph@codesourcery.com>2016-02-18 22:54:07 +0000
commit0fed79a8279bb4d4483895a742457946faf89594 (patch)
treee4f4e236dd13cfe9d95a18981c7c7a8f395f571c /ChangeLog
parente2c631384a1f9795514d8a7303838070ea81e2ec (diff)
downloadglibc-0fed79a8279bb4d4483895a742457946faf89594.tar.gz
glibc-0fed79a8279bb4d4483895a742457946faf89594.tar.xz
glibc-0fed79a8279bb4d4483895a742457946faf89594.zip
Fix ldbl-128ibm fmodl handling of equal arguments with low part zero (bug 19602).
The ldbl-128ibm implementation of fmodl has logic to detect when the
first argument has absolute value less than or equal to the second.
This logic is only correct for nonzero low parts; if the high parts
are equal and the low parts are zero, then the signs of the low parts
(which have no semantic effect on the value of the long double number)
can result in equal values being wrongly treated as unequal, and an
incorrect result being returned from fmodl.  This patch fixes this by
checking for the case of zero low parts.

Although this does show up in tests from libm-test.inc (both tests of
fmodl, and, indirectly, of remainderl / dreml), the dependence on
non-semantic zero low parts means that test shouldn't be expected to
reproduce it reliably; thus, this patch adds a standalone test that
sets up affected values using unions.

Tested for powerpc.

	[BZ #19602]
	* sysdeps/ieee754/ldbl-128ibm/e_fmodl.c (__ieee754_fmodl): Handle
	equal high parts and both low parts zero specially.
	* sysdeps/ieee754/ldbl-128ibm/test-fmodl-ldbl-128ibm.c: New test.
	* sysdeps/ieee754/ldbl-128ibm/Makefile [$(subdir) = math] (tests):
	Add test-fmodl-ldbl-128ibm.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog7
1 files changed, 7 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 48d800c885..3e480edb1a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2016-02-18  Joseph Myers  <joseph@codesourcery.com>
 
+	[BZ #19602]
+	* sysdeps/ieee754/ldbl-128ibm/e_fmodl.c (__ieee754_fmodl): Handle
+	equal high parts and both low parts zero specially.
+	* sysdeps/ieee754/ldbl-128ibm/test-fmodl-ldbl-128ibm.c: New test.
+	* sysdeps/ieee754/ldbl-128ibm/Makefile [$(subdir) = math] (tests):
+	Add test-fmodl-ldbl-128ibm.
+
 	[BZ #19595]
 	* sysdeps/ieee754/ldbl-128ibm/e_fmodl.c (__ieee754_fmodl): Use
 	common logic for all cases of shifting subnormal results.  Do not