diff options
| author | Carlos O'Donell <carlos@redhat.com> | 2016-06-02 23:30:11 -0400 |
|---|---|---|
| committer | Carlos O'Donell <carlos@redhat.com> | 2016-06-02 23:52:06 -0400 |
| commit | 1c1e7fb65828c99d6e0f0f3857089b559a0c8189 (patch) | |
| tree | ec54f58a6ecbbc2380b9f1e7a8d6b1ab21a7c235 /ChangeLog | |
| parent | f06f3f05b48c72e2c9b0fa78671f94fd22d67da8 (diff) | |
| download | glibc-1c1e7fb65828c99d6e0f0f3857089b559a0c8189.tar.gz glibc-1c1e7fb65828c99d6e0f0f3857089b559a0c8189.tar.xz glibc-1c1e7fb65828c99d6e0f0f3857089b559a0c8189.zip | |
Fix macro API for __USE_KERNEL_IPV6_DEFS.
The use of __USE_KERNEL_IPV6_DEFS with ifndef is bad practice per: https://sourceware.org/glibc/wiki/Wundef. This change moves it to use 'if' and always define the macro. Please note that this is not the only problem with this code. I have a series of fixes after this one to resolve breakage with this code and add regression tests for it via compile-only source testing (to be discussed in another thread). Unfortunately __USE_KERNEL_XATTR_DEFS is set by the kernel and not glibc, and uses 'define', so we can't fix that yet.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 7dfe5752a7..4e7fd30b49 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2016-06-02 Carlos O'Donell <carlos@redhat.com> + + * sysdeps/unix/sysv/linux/bits/in.h [defined _UAPI_LINUX_IN6_H || + defined _UAPI_IPV6_H]: Define __USE_KERNEL_IPV6_DEFS to 1. + [!(defined _UAPI_LINUX_IN6_H || defined _UAPI_IPV6_H)]: Define + __USE_KERNEL_IPV6_DEFS to 0. + * inet/netinet/in.h: Use '#if !__USE_KERNEL_IPV6_DEFS'. + Update comment. + 2016-06-01 Florian Weimer <fweimer@redhat.com> [BZ #19861] |