From 1c1e7fb65828c99d6e0f0f3857089b559a0c8189 Mon Sep 17 00:00:00 2001 From: Carlos O'Donell Date: Thu, 2 Jun 2016 23:30:11 -0400 Subject: Fix macro API for __USE_KERNEL_IPV6_DEFS. The use of __USE_KERNEL_IPV6_DEFS with ifndef is bad practice per: https://sourceware.org/glibc/wiki/Wundef. This change moves it to use 'if' and always define the macro. Please note that this is not the only problem with this code. I have a series of fixes after this one to resolve breakage with this code and add regression tests for it via compile-only source testing (to be discussed in another thread). Unfortunately __USE_KERNEL_XATTR_DEFS is set by the kernel and not glibc, and uses 'define', so we can't fix that yet. --- ChangeLog | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 7dfe5752a7..4e7fd30b49 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2016-06-02 Carlos O'Donell + + * sysdeps/unix/sysv/linux/bits/in.h [defined _UAPI_LINUX_IN6_H || + defined _UAPI_IPV6_H]: Define __USE_KERNEL_IPV6_DEFS to 1. + [!(defined _UAPI_LINUX_IN6_H || defined _UAPI_IPV6_H)]: Define + __USE_KERNEL_IPV6_DEFS to 0. + * inet/netinet/in.h: Use '#if !__USE_KERNEL_IPV6_DEFS'. + Update comment. + 2016-06-01 Florian Weimer [BZ #19861] -- cgit 1.4.1