about summary refs log tree commit diff
diff options
context:
space:
mode:
authorStafford Horne <shorne@gmail.com>2021-01-08 06:45:36 +0900
committerStafford Horne <shorne@gmail.com>2021-01-15 11:24:04 +0900
commitcc528f9a7e51f769ea79a9c413af417671bcc695 (patch)
tree849cd845d97c5081cd2fb68a78cd1bf1cd4a18d2
parent2d651eb9265d1366d7b9e881bfddd46db9c1ecc4 (diff)
downloadglibc-cc528f9a7e51f769ea79a9c413af417671bcc695.tar.gz
glibc-cc528f9a7e51f769ea79a9c413af417671bcc695.tar.xz
glibc-cc528f9a7e51f769ea79a9c413af417671bcc695.zip
math/test-tgmath2: Fix fabs failure when no long double
I have been testing with GCC trunk and GLIBC master while working on the
OpenRISC port.  This test has been failing with fabs not being called,
This is caused as my architecture is configure with no long double
meaning the two calls are the same:

  TEST (fabs (Vdouble1), double, fabs);
  TEST (fabs (Vldouble1), ldouble, fabs);

Instead of the tgmath calls resolving to fabs and fabsl both calls are
fabs.  Next, do to compiler optimiations the second call is eliminated.
Fix this by invoking the failing TEST with Vldouble2.

Note, I also updated the FAIL message to more clearly show where the
failure happened, so I see:

  FAIL: math/test-tgmath2
  original exit status 1
  wrong function called, fabs (ldouble) failure on line 174

Cc: Joseph Myers <joseph@codesourcery.com>
-rw-r--r--math/test-tgmath2.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/math/test-tgmath2.c b/math/test-tgmath2.c
index 14a3453169..b8fb00c566 100644
--- a/math/test-tgmath2.c
+++ b/math/test-tgmath2.c
@@ -122,7 +122,7 @@ int counts[Tlast][C_last];
       __asm __volatile ("" : : "r" (&texpr));			\
       if (count != 1 || counts[T##type][C_##fn] != 1)		\
 	{							\
-	  FAIL ("wrong function called");			\
+	  FAIL ("wrong function called, "#fn" ("#type")");	\
 	  memset (counts, 0, sizeof (counts));			\
 	}							\
       count = 0;						\
@@ -171,7 +171,7 @@ test_fabs (const int Vint4, const long long int Vllong4)
   TEST (fabs (vcldouble1), ldouble, cabs);
   TEST (fabs (Vfloat1), float, fabs);
   TEST (fabs (Vdouble1), double, fabs);
-  TEST (fabs (Vldouble1), ldouble, fabs);
+  TEST (fabs (Vldouble2), ldouble, fabs);
 #ifndef __OPTIMIZE__
   /* GCC is too smart to optimize these out.  */
   TEST (fabs (Vint1), double, fabs);