about summary refs log tree commit diff
diff options
context:
space:
mode:
authorUlrich Drepper <drepper@redhat.com>2007-05-08 03:27:35 +0000
committerUlrich Drepper <drepper@redhat.com>2007-05-08 03:27:35 +0000
commitc306d807358c5ef73f7cd7d79e5f401c60892ca4 (patch)
tree97e3f4e4985bb6f0ef8833f8639e1828ac408473
parent37f402350d24576e21f81a209e77705932f0181f (diff)
downloadglibc-c306d807358c5ef73f7cd7d79e5f401c60892ca4.tar.gz
glibc-c306d807358c5ef73f7cd7d79e5f401c60892ca4.tar.xz
glibc-c306d807358c5ef73f7cd7d79e5f401c60892ca4.zip
(strfry): Make result more random.
-rw-r--r--string/strfry.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/string/strfry.c b/string/strfry.c
index 112dd4adb3..a8b202d176 100644
--- a/string/strfry.c
+++ b/string/strfry.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 1992, 1996, 1999, 2002 Free Software Foundation, Inc.
+/* Copyright (C) 1992, 1996, 1999, 2002, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -37,16 +37,14 @@ strfry (char *string)
       init = 1;
     }
 
-  len = strlen (string);
+  len = strlen (string) - 1;
   for (i = 0; i < len; ++i)
     {
       int32_t j;
-      char c;
-
       __random_r (&rdata, &j);
-      j %= len;
+      j = j % len + 1;
 
-      c = string[i];
+      char c = string[i];
       string[i] = string[j];
       string[j] = c;
     }