about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2022-12-29 09:58:00 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2023-01-11 17:50:25 -0300
commit8176efe3cabeee003f193f6b877297bf5aee8eb6 (patch)
treec28d065062effada61336864ba40ae86213c7ab6
parent0b3503e2e19602db9cda47915d19a26c00f59bb1 (diff)
downloadglibc-8176efe3cabeee003f193f6b877297bf5aee8eb6.tar.gz
glibc-8176efe3cabeee003f193f6b877297bf5aee8eb6.tar.xz
glibc-8176efe3cabeee003f193f6b877297bf5aee8eb6.zip
sunrpc: Suppress GCC -O1 warning on user2netname [BZ #19444]
The same issue described by 6128e82ebe973163d2dd614d31753c88c0c4d645
also happend with -O1.

Checked on x86_64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
-rw-r--r--sunrpc/netname.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/sunrpc/netname.c b/sunrpc/netname.c
index 4fde0bf91c..dd2cb1b441 100644
--- a/sunrpc/netname.c
+++ b/sunrpc/netname.c
@@ -49,10 +49,11 @@ user2netname (char netname[MAXNETNAMELEN + 1], const uid_t uid,
   if ((strlen (dfltdom) + OPSYS_LEN + 3 + MAXIPRINT) > (size_t) MAXNETNAMELEN)
     return 0;
 
-  /* GCC with -Os warns that sprint might overflow while handling dfltdom,
-     however the above test does check if an overflow would happen.  */
+  /* GCC with -Os or -O1 warns that sprint might overflow while handling
+     dfltdom, however the above test does check if an overflow would
+     happen.  */
   DIAG_PUSH_NEEDS_COMMENT;
-  DIAG_IGNORE_Os_NEEDS_COMMENT (8, "-Wformat-overflow");
+  DIAG_IGNORE_NEEDS_COMMENT (8, "-Wformat-overflow");
   sprintf (netname, "%s.%d@%s", OPSYS, uid, dfltdom);
   DIAG_POP_NEEDS_COMMENT;
   i = strlen (netname);