about summary refs log tree commit diff
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@redhat.com>2014-02-27 21:29:16 +0530
committerMike Frysinger <vapier@gentoo.org>2014-06-14 18:44:28 -0400
commit4545280f9c1ab06efa9348ab46bac436f5885244 (patch)
treec28c89e391c7a0337e5c3ddbcd591d83d09923cc
parente1449bcd91f738ea4b0b6d75bb3e1f21827cf047 (diff)
downloadglibc-4545280f9c1ab06efa9348ab46bac436f5885244.tar.gz
glibc-4545280f9c1ab06efa9348ab46bac436f5885244.tar.xz
glibc-4545280f9c1ab06efa9348ab46bac436f5885244.zip
Fix sign of input to bsloww1 (BZ #16623)
In 84ba214c, I removed some redundant sign computations and in the
process, I incorrectly got rid of a temporary variable, thus passing
the absolute value of the input to bsloww1.  This caused #16623.

This fix undoes the incorrect change.

(cherry picked from commit ffe768a90912f9bce43b70a82576b3dc99e3121c)

https://bugs.gentoo.org/509494
https://sourceware.org/bugzilla/show_bug.cgi?id=16623
-rw-r--r--sysdeps/ieee754/dbl-64/s_sin.c16
1 files changed, 10 insertions, 6 deletions
diff --git a/sysdeps/ieee754/dbl-64/s_sin.c b/sysdeps/ieee754/dbl-64/s_sin.c
index 6105e9fbdf..50109b8dd4 100644
--- a/sysdeps/ieee754/dbl-64/s_sin.c
+++ b/sysdeps/ieee754/dbl-64/s_sin.c
@@ -447,19 +447,21 @@ __sin (double x)
 	    }
 	  else
 	    {
+	      double t;
 	      if (a > 0)
 		{
 		  m = 1;
+		  t = a;
 		  db = da;
 		}
 	      else
 		{
 		  m = 0;
-		  a = -a;
+		  t = -a;
 		  db = -da;
 		}
-	      u.x = big + a;
-	      y = a - (u.x - big);
+	      u.x = big + t;
+	      y = t - (u.x - big);
 	      res = do_sin (u, y, db, &cor);
 	      cor = (cor > 0) ? 1.035 * cor + eps : 1.035 * cor - eps;
 	      retval = ((res == res + cor) ? ((m) ? res : -res)
@@ -671,19 +673,21 @@ __cos (double x)
 	    }
 	  else
 	    {
+	      double t;
 	      if (a > 0)
 		{
 		  m = 1;
+		  t = a;
 		  db = da;
 		}
 	      else
 		{
 		  m = 0;
-		  a = -a;
+		  t = -a;
 		  db = -da;
 		}
-	      u.x = big + a;
-	      y = a - (u.x - big);
+	      u.x = big + t;
+	      y = t - (u.x - big);
 	      res = do_sin (u, y, db, &cor);
 	      cor = (cor > 0) ? 1.035 * cor + eps : 1.035 * cor - eps;
 	      retval = ((res == res + cor) ? ((m) ? res : -res)