about summary refs log tree commit diff
diff options
context:
space:
mode:
authorTulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>2018-01-05 18:34:09 -0200
committerTulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>2018-01-05 18:34:09 -0200
commit3a32b7168d9f49eed5615ca17c9a8bd53cfe94ed (patch)
treed87446981d932b3796ce000f6f1b2197c3b54be3
parenta6d0afb5075486773c4c70119a9bd9cd78faec9e (diff)
downloadglibc-3a32b7168d9f49eed5615ca17c9a8bd53cfe94ed.tar.gz
glibc-3a32b7168d9f49eed5615ca17c9a8bd53cfe94ed.tar.xz
glibc-3a32b7168d9f49eed5615ca17c9a8bd53cfe94ed.zip
powerpc: Fix error message during relocation overflow
The function _itoa_word() writes characters from the higher address to
the lower address, requiring the destination string to reserve that size
before calling it.

	* sysdeps/powerpc/powerpc64/dl-machine.c (_dl_reloc_overflow):
	Reserve 16 chars to reloc_addr before calling _itoa_word.

Signed-off-by: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
-rw-r--r--ChangeLog5
-rw-r--r--sysdeps/powerpc/powerpc64/dl-machine.c5
2 files changed, 9 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 8928d9bed2..7a09e8e44a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-05  Tulio Magno Quites Machado Filho  <tuliom@linux.vnet.ibm.com>
+
+	* sysdeps/powerpc/powerpc64/dl-machine.c (_dl_reloc_overflow):
+	Reserve 16 chars to reloc_addr before calling _itoa_word.
+
 2018-01-05  Aurelien Jarno  <aurelien@aurel32.net>
 
 	[BZ #22678]
diff --git a/sysdeps/powerpc/powerpc64/dl-machine.c b/sysdeps/powerpc/powerpc64/dl-machine.c
index d732a854ea..959907bf02 100644
--- a/sysdeps/powerpc/powerpc64/dl-machine.c
+++ b/sysdeps/powerpc/powerpc64/dl-machine.c
@@ -31,7 +31,10 @@ _dl_reloc_overflow (struct link_map *map,
   char buffer[1024];
   char *t;
   t = stpcpy (buffer, name);
-  t = stpcpy (t, " reloc at 0x");
+  /* Notice that _itoa_word() writes characters from the higher address to the
+     lower address, requiring the destination string to reserve all the
+     required size before the call.  */
+  t = stpcpy (t, " reloc at 0x0000000000000000");
   _itoa_word ((unsigned long) reloc_addr, t, 16, 0);
   if (refsym)
     {