diff options
| author | Andreas Schwab <schwab@redhat.com> | 2011-09-26 17:49:14 +0200 |
|---|---|---|
| committer | Andreas Schwab <schwab@redhat.com> | 2011-09-27 09:55:28 +0200 |
| commit | 32c76b63be605d12314e0c6ac2bd702c883d1423 (patch) | |
| tree | f42aeb09e253e1667a91a36b358187b2fd110d71 | |
| parent | bf972c9dfcda9f95e337c6d4586abcc3bdf46561 (diff) | |
| download | glibc-32c76b63be605d12314e0c6ac2bd702c883d1423.tar.gz glibc-32c76b63be605d12314e0c6ac2bd702c883d1423.tar.xz glibc-32c76b63be605d12314e0c6ac2bd702c883d1423.zip | |
Correctly reparse group line after enlarging the buffer
| -rw-r--r-- | ChangeLog | 5 | ||||
| -rw-r--r-- | nss/nss_files/files-initgroups.c | 12 |
2 files changed, 13 insertions, 4 deletions
diff --git a/ChangeLog b/ChangeLog index 1047cce2bb..716d8059aa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-09-27 Andreas Schwab <schwab@redhat.com> + + * nss/nss_files/files-initgroups.c (_nss_files_initgroups_dyn): + Reread the line before reparsing it. + 2011-09-26 Andreas Schwab <schwab@redhat.com> * sysdeps/x86_64/fpu/bits/mathinline.h: Use __asm instead of asm. diff --git a/nss/nss_files/files-initgroups.c b/nss/nss_files/files-initgroups.c index 113abf2821..c343b35e56 100644 --- a/nss/nss_files/files-initgroups.c +++ b/nss/nss_files/files-initgroups.c @@ -52,8 +52,10 @@ _nss_files_initgroups_dyn (const char *user, gid_t group, long int *start, gid_t *groups = *groupsp; /* We have to iterate over the entire file. */ - while (!feof_unlocked (stream)) + while (1) { + fpos_t pos; + fgetpos (stream, &pos); ssize_t n = getline (&line, &linelen, stream); if (n < 0) { @@ -64,9 +66,8 @@ _nss_files_initgroups_dyn (const char *user, gid_t group, long int *start, } struct group grp; - int res; - while ((res = _nss_files_parse_grent (line, &grp, buffer, buflen, - errnop)) == -1) + int res = _nss_files_parse_grent (line, &grp, buffer, buflen, errnop); + if (res == -1) { size_t newbuflen = 2 * buflen; if (buffer_use_malloc || ! __libc_use_alloca (buflen + newbuflen)) @@ -85,6 +86,9 @@ _nss_files_initgroups_dyn (const char *user, gid_t group, long int *start, } else buffer = extend_alloca (buffer, buflen, newbuflen); + /* Reread current line, the parser has clobbered it. */ + fsetpos (stream, &pos); + continue; } if (res > 0 && grp.gr_gid != group) |