about summary refs log tree commit diff
diff options
context:
space:
mode:
authorXi Ruoyao <xry111@mengyan1223.wang>2021-08-12 20:31:59 +0000
committerJoseph Myers <joseph@codesourcery.com>2021-08-12 20:31:59 +0000
commit1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe (patch)
tree9b5f6e6de2fc456934a0c40ec0e0fb6bf4b9ea83
parent4cc79c217744743077bf7a0ec5e0a4318f1e6641 (diff)
downloadglibc-1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe.tar.gz
glibc-1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe.tar.xz
glibc-1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe.zip
mips: align stack in clone [BZ #28223]
The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32
ABI require 8 byte aligned stack.  Previously if the caller passed an
unaligned stack to clone the the child misbehaved.

Fixes bug 28223.
-rw-r--r--sysdeps/unix/sysv/linux/mips/clone.S7
1 files changed, 7 insertions, 0 deletions
diff --git a/sysdeps/unix/sysv/linux/mips/clone.S b/sysdeps/unix/sysv/linux/mips/clone.S
index 71d9dba8bd..43a5ad3a40 100644
--- a/sysdeps/unix/sysv/linux/mips/clone.S
+++ b/sysdeps/unix/sysv/linux/mips/clone.S
@@ -55,6 +55,13 @@ NESTED(__clone,4*SZREG,sp)
 	.set		at
 #endif
 
+	/* Align stack to 4/8 bytes per the ABI.  */
+#if _MIPS_SIM == _ABIO32
+	li		t0,-4
+#else
+	li		t0,-8
+#endif
+	and		a1,a1,t0
 
 	/* Sanity check arguments.  */
 	li		v0,EINVAL