From 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Thu, 12 Aug 2021 20:31:59 +0000 Subject: mips: align stack in clone [BZ #28223] The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32 ABI require 8 byte aligned stack. Previously if the caller passed an unaligned stack to clone the the child misbehaved. Fixes bug 28223. --- sysdeps/unix/sysv/linux/mips/clone.S | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sysdeps/unix/sysv/linux/mips/clone.S b/sysdeps/unix/sysv/linux/mips/clone.S index 71d9dba8bd..43a5ad3a40 100644 --- a/sysdeps/unix/sysv/linux/mips/clone.S +++ b/sysdeps/unix/sysv/linux/mips/clone.S @@ -55,6 +55,13 @@ NESTED(__clone,4*SZREG,sp) .set at #endif + /* Align stack to 4/8 bytes per the ABI. */ +#if _MIPS_SIM == _ABIO32 + li t0,-4 +#else + li t0,-8 +#endif + and a1,a1,t0 /* Sanity check arguments. */ li v0,EINVAL -- cgit 1.4.1