diff options
author | okan <okan> | 2014-08-22 19:04:00 +0000 |
---|---|---|
committer | okan <okan> | 2014-08-22 19:04:00 +0000 |
commit | fe533fdc8edb2584b40a8bad9f00b8258529854f (patch) | |
tree | a25ef79ccd5141c92bc3bc4915885c81f6afc0f3 /group.c | |
parent | b31b09dfc26b4b17c025d7196b8b5a4a26f599df (diff) | |
download | cwm-fe533fdc8edb2584b40a8bad9f00b8258529854f.tar.gz cwm-fe533fdc8edb2584b40a8bad9f00b8258529854f.tar.xz cwm-fe533fdc8edb2584b40a8bad9f00b8258529854f.zip |
Fix nogroup regression, where nogroup became an actual group - the
symantics between cwm groups and ewmh got in the way. Ensure a client that wants to be in nogroup stays in nogroup (thus stays in view), even when (re)reading NET_WM_DESKTOP. Paritially reverts patchset 644 (2014-02-07 13:09 PST) which deals with a NULL cc->group. All to be revisited when NET_WM_STATE_STICKY hits cwm. Reported by many; testing and ok phessler.
Diffstat (limited to 'group.c')
-rw-r--r-- | group.c | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/group.c b/group.c index ef93de3..16e274d 100644 --- a/group.c +++ b/group.c @@ -48,17 +48,14 @@ const char *num_to_name[] = { static void group_assign(struct group_ctx *gc, struct client_ctx *cc) { - if (gc == NULL) - gc = TAILQ_FIRST(&cc->sc->groupq); - if (cc->group == gc) - return; - if (cc->group != NULL) TAILQ_REMOVE(&cc->group->clients, cc, group_entry); - TAILQ_INSERT_TAIL(&gc->clients, cc, group_entry); cc->group = gc; + if (cc->group != NULL) + TAILQ_INSERT_TAIL(&gc->clients, cc, group_entry); + xu_ewmh_net_wm_desktop(cc); } @@ -354,7 +351,7 @@ group_autogroup(struct client_ctx *cc) struct screen_ctx *sc = cc->sc; struct autogroupwin *aw; struct group_ctx *gc; - int num = -1, both_match = 0; + int num = -2, both_match = 0; long *grpnum; if (cc->ch.res_class == NULL || cc->ch.res_name == NULL) @@ -362,12 +359,9 @@ group_autogroup(struct client_ctx *cc) if (xu_getprop(cc->win, ewmh[_NET_WM_DESKTOP], XA_CARDINAL, 1, (unsigned char **)&grpnum) > 0) { - if (*grpnum == -1) - num = 0; - else if (*grpnum > CALMWM_NGROUPS || *grpnum < 0) + num = *grpnum; + if (num > CALMWM_NGROUPS || num < -1) num = CALMWM_NGROUPS - 1; - else - num = *grpnum; XFree(grpnum); } else { TAILQ_FOREACH(aw, &Conf.autogroupq, entry) { @@ -382,6 +376,11 @@ group_autogroup(struct client_ctx *cc) } } + if ((num == -1) || (num == 0)) { + group_assign(NULL, cc); + return; + } + TAILQ_FOREACH(gc, &sc->groupq, entry) { if (gc->num == num) { group_assign(gc, cc); |