From 9eadebb67a12780b2923c1d28dc0c3091707f14e Mon Sep 17 00:00:00 2001 From: Christian Neukirchen Date: Sat, 11 Oct 2014 21:24:52 +0200 Subject: xlint: construct $variables only once --- xlint | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xlint b/xlint index 85bf5f4..1303340 100755 --- a/xlint +++ b/xlint @@ -7,7 +7,7 @@ scan() { sed "s/^\([^:]*:[^:]*:\)\(.*\)/\1 $msg/" } -variables="#.* +variables=$(echo -n "#.* _.* .*_descr .*_homedir @@ -76,7 +76,7 @@ systemd_services triggers version wrksrc -xml_entries" +xml_entries" | tr '\n' '|') for template; do scan 'short_desc=.*\."' "unwanted trailing dot in short_desc" @@ -92,7 +92,7 @@ for template; do scan 'replaces=[^<>]*$' "replaces needs depname with version" scan 'conflicts=[^<>]*$' "conflicts needs depname with version" scan 'maintainer=(?!.*<.*@.*>).*' "maintainer needs email address" - scan '^(?!\s*('"$(echo -n "$variables" | tr '\n' '|')"'))[^\s=-]+=' \ + scan '^(?!\s*('"$variables"'))[^\s=-]+=' \ "custom variables should use _ prefix: \2" -1 scan '^[^ =]*=(""|''|)$' "variable set to empty string: \2" -1 done -- cgit 1.4.1