From a2320e50b375576fbe0e72636c4900bcc4704b80 Mon Sep 17 00:00:00 2001 From: Christopher Brannon Date: Thu, 21 Jun 2018 21:22:19 -0700 Subject: vlogger: a couple of bugfixes. * Don't store the return value of getopt in a char. Storing in a char and comparing against -1 breaks on ARM, where char is unsigned. * The line argument to getline should point at a NULL char *. Otherwise, getline will treat *line as a pointer to an allocated buffer. With a little extra work, we could reuse the buffer, but always calling getline with *line == NULL is safe. Closes: #2 [via git-merge-pr] --- vlogger.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vlogger.c b/vlogger.c index cd32143..debad36 100644 --- a/vlogger.c +++ b/vlogger.c @@ -76,8 +76,9 @@ strpriority(char *s, int *facility, int *level) int main(int argc, char *argv[]) { - char c, *p, *argv0; + char *p, *argv0; char *tag = NULL; + int c; int facility = LOG_DAEMON; int level = LOG_INFO; @@ -116,7 +117,7 @@ usage: openlog(tag, 0, facility); - char *line; + char *line = NULL; size_t linelen = 0; ssize_t rd; while ((rd = getline(&line, &linelen, stdin)) != -1) { -- cgit 1.4.1