From d97e2f3a64b09a748bb0984fba33f3595298853a Mon Sep 17 00:00:00 2001 From: giraffedata Date: Sun, 9 Dec 2007 17:30:47 +0000 Subject: fix overflow calculation git-svn-id: http://svn.code.sf.net/p/netpbm/code/trunk@479 9d0c8265-081b-0410-96cb-a4ca84ce46f8 --- lib/fileio.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'lib/fileio.c') diff --git a/lib/fileio.c b/lib/fileio.c index d891b05a..300ae303 100644 --- a/lib/fileio.c +++ b/lib/fileio.c @@ -85,10 +85,18 @@ pm_getuint(FILE * const ifP) { do { unsigned int const digitVal = ch - '0'; - if (i > INT_MAX/10 - digitVal) + if (i > INT_MAX/10) pm_error("ASCII decimal integer in file is " "too large to be processed. "); - i = i * 10 + digitVal; + + i *= 10; + + if (i > INT_MAX - digitVal) + pm_error("ASCII decimal integer in file is " + "too large to be processed. "); + + i += digitVal; + ch = pm_getc(ifP); } while (ch >= '0' && ch <= '9'); -- cgit 1.4.1