about summary refs log tree commit diff
diff options
context:
space:
mode:
authorgiraffedata <giraffedata@9d0c8265-081b-0410-96cb-a4ca84ce46f8>2020-12-28 00:53:05 +0000
committergiraffedata <giraffedata@9d0c8265-081b-0410-96cb-a4ca84ce46f8>2020-12-28 00:53:05 +0000
commitf7b295a44af818ffaaa3a96644ea390503463573 (patch)
tree9f0ebe29a42bab73a9a44c9b13fa41b090b9d7f4
parent13ddd6e6ae24808acf0815de4e99868ffb094ed4 (diff)
downloadnetpbm-mirror-f7b295a44af818ffaaa3a96644ea390503463573.tar.gz
netpbm-mirror-f7b295a44af818ffaaa3a96644ea390503463573.tar.xz
netpbm-mirror-f7b295a44af818ffaaa3a96644ea390503463573.zip
Release 10.73.34
git-svn-id: http://svn.code.sf.net/p/netpbm/code/super_stable@4012 9d0c8265-081b-0410-96cb-a4ca84ce46f8
-rw-r--r--doc/HISTORY13
-rw-r--r--editor/pamaddnoise.c2
-rw-r--r--other/pamarith.c10
-rw-r--r--version.mk2
4 files changed, 21 insertions, 6 deletions
diff --git a/doc/HISTORY b/doc/HISTORY
index eca25102..c90d602d 100644
--- a/doc/HISTORY
+++ b/doc/HISTORY
@@ -4,6 +4,15 @@ Netpbm.
 CHANGE HISTORY 
 --------------
 
+not yet  BJH  Release 10.73.34
+
+              pamarith: Fix bug: fails with more than two operands for
+              -mulitply, -minimum, -maximum, -nand, and -nor.
+
+              pamaddnoise: fix bug: garbage output with -type impulse.  Always
+              broken (pamaddnoise's precursors pnmaddnoise was new to Netpbm
+              in Netpbm 10.29 (August 2005).
+
 20.09.26 BJH  Release 10.73.33
 
               pamfunc: Fix always wrong output with -not.  Always broken.
@@ -1533,6 +1542,10 @@ CHANGE HISTORY
 
               Add ppmtoascii.  Thanks "Frank Ch. Eigler" <fche@elastic.org>.
 
+              pamarith: Allow more than two operands for functions for which
+              it makes sense (all but -subtract, -difference, -compare,
+              -divide, -shiftleft, and -shiftright).
+
               pnmtops: Add -bitsperpixel option.
 
               pamx: Make exit status 0 instead of 10 when window manager
diff --git a/editor/pamaddnoise.c b/editor/pamaddnoise.c
index cf1af815..a88a5b93 100644
--- a/editor/pamaddnoise.c
+++ b/editor/pamaddnoise.c
@@ -97,6 +97,8 @@ impulse_noise(sample   const maxval,
         *newSampleP = 0;
     else if ( sap >= high_tol )
         *newSampleP = maxval;
+    else
+        *newSampleP = origSample;
 }
 
 
diff --git a/other/pamarith.c b/other/pamarith.c
index 3fde1953..3f44dc73 100644
--- a/other/pamarith.c
+++ b/other/pamarith.c
@@ -22,21 +22,21 @@ isDyadic(enum function const function) {
     
     switch (function) {
     case FN_ADD:
+    case FN_MULTIPLY:
+    case FN_MINIMUM:
+    case FN_MAXIMUM:
     case FN_MEAN:
     case FN_AND:
+    case FN_NAND:
     case FN_OR:
+    case FN_NOR:
     case FN_XOR:
         retval = FALSE;
         break;
     case FN_SUBTRACT:
     case FN_DIFFERENCE:
-    case FN_MINIMUM:
-    case FN_MAXIMUM:
     case FN_COMPARE:
-    case FN_MULTIPLY:
     case FN_DIVIDE:
-    case FN_NAND:
-    case FN_NOR:
     case FN_SHIFTLEFT:
     case FN_SHIFTRIGHT:
         retval = TRUE;
diff --git a/version.mk b/version.mk
index 904a29cc..d4858885 100644
--- a/version.mk
+++ b/version.mk
@@ -1,3 +1,3 @@
 NETPBM_MAJOR_RELEASE = 10
 NETPBM_MINOR_RELEASE = 73
-NETPBM_POINT_RELEASE = 33
+NETPBM_POINT_RELEASE = 34