From 39ab9952e8255cb99e9c0abcc8bbec43158a55d7 Mon Sep 17 00:00:00 2001
From: Peter Stephenson
Date: Sat, 20 Jul 2013 23:23:18 +0100
Subject: 31545: Use of FD_CLOEXEC to remove possibility of fd reuse. File
descriptors of mmap'd dump files are closed if and only if an exec is
performed.
---
Src/parse.c | 7 +++++++
1 file changed, 7 insertions(+)
(limited to 'Src/parse.c')
diff --git a/Src/parse.c b/Src/parse.c
index 753080d70..b670925de 100644
--- a/Src/parse.c
+++ b/Src/parse.c
@@ -3171,6 +3171,9 @@ load_dump_file(char *dump, struct stat *sbuf, int other, int len)
d->dev = sbuf->st_dev;
d->ino = sbuf->st_ino;
d->fd = fd;
+#ifdef FD_CLOEXEC
+ fcntl(fd, F_SETFD, FD_CLOEXEC);
+#endif
d->map = addr + (other ? (len - off) / sizeof(wordcode) : 0);
d->addr = addr;
d->len = len;
@@ -3439,6 +3442,7 @@ decrdumpcount(FuncDump f)
}
}
+#ifndef FD_CLOEXEC
/**/
mod_export void
closedumps(void)
@@ -3448,6 +3452,7 @@ closedumps(void)
for (p = dumps; p; p = p->next)
zclose(p->fd);
}
+#endif
#else
@@ -3461,11 +3466,13 @@ decrdumpcount(FuncDump f)
{
}
+#ifndef FD_CLOEXEC
/**/
mod_export void
closedumps(void)
{
}
+#endif
#endif
--
cgit 1.4.1