From c2c50bd0a0778217d18ebe7ed36bbb88985a9736 Mon Sep 17 00:00:00 2001 From: Peter Stephenson Date: Fri, 15 Jun 2007 10:02:24 +0000 Subject: 23553: bit missed out --- Src/math.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'Src/math.c') diff --git a/Src/math.c b/Src/math.c index 66d57fd53..e1cde5f03 100644 --- a/Src/math.c +++ b/Src/math.c @@ -1061,8 +1061,19 @@ mathevall(char *s, int prek, char **ep) "BUG: math: wallabies roaming too freely in outback"); if (errflag) { + /* + * This used to set the return value to errflag. + * I don't understand how that could be useful; the + * caller doesn't know that's what's happened and + * may not get a value at all. + * Worse, we reset errflag in execarith() and setting + * this explicitly non-zero means a (( ... )) returns + * status 0 if there's an error. That surely can't + * be right. execarith() now detects an error and returns + * status 2. + */ ret.type = MN_INTEGER; - ret.u.l = errflag; + ret.u.l = 0; } else { if (stack[0].val.type == MN_UNSET) ret = getnparam(stack[0].lval); -- cgit 1.4.1