From fb5cba5bb73631e54796c5964d6aa81b15a7f1c7 Mon Sep 17 00:00:00 2001 From: Oliver Kiddle Date: Thu, 13 Nov 2003 15:10:21 +0000 Subject: merge back changes from 4.1 (17567, 17569) --- ChangeLog | 9 +++++++++ Src/Zle/zle_main.c | 1 + Src/Zle/zle_thingy.c | 2 ++ Src/Zle/zle_tricky.c | 11 ++++++++++- 4 files changed, 22 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 9e80671ea..0cf1bb3ad 100644 --- a/ChangeLog +++ b/ChangeLog @@ -692,6 +692,15 @@ * 17571: Src/Modules/terminfo.c: backport of terminfo segfault fix from 4.1. +2002-08-20 Sven Wischnowsky + + * 17569: Src/Zle/zle_tricky.c: fix typo in comment + + * 17567: Src/Zle/zle_main.c, Src/Zle/zle_thingy.c, + Src/Zle/zle_tricky.c: fix default completion module loading, + use compctl if it hasn't been loaded already and no completion + widgets have been defined + 2002-08-19 Oliver Kiddle * unposted: Completion/X/Command/_nedit, Completion/Unix/Command/_mail, diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c index c5225ccdb..cb1854e9b 100644 --- a/Src/Zle/zle_main.c +++ b/Src/Zle/zle_main.c @@ -1138,6 +1138,7 @@ setup_(Module m) varedarg = NULL; incompfunc = incompctlfunc = hascompmod = 0; + hascompwidgets = 0; clwords = (char **) zshcalloc((clwsize = 16) * sizeof(char *)); diff --git a/Src/Zle/zle_thingy.c b/Src/Zle/zle_thingy.c index f40bd18b8..142fc263d 100644 --- a/Src/Zle/zle_thingy.c +++ b/Src/Zle/zle_thingy.c @@ -588,6 +588,8 @@ bin_zle_complete(char *name, char **args, char *ops, char func) zwarnnam(name, "widget name `%s' is protected", args[0], 0); return 1; } + hascompwidgets++; + return 0; } diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c index c98c8b526..abede4a96 100644 --- a/Src/Zle/zle_tricky.c +++ b/Src/Zle/zle_tricky.c @@ -150,6 +150,11 @@ mod_export int cfret; /**/ mod_export int comprecursive; +/* != 0 if there are any defined completion widgets. */ + +/**/ +int hascompwidgets; + /* Find out if we have to insert a tab (instead of trying to complete). */ /**/ @@ -554,7 +559,11 @@ docomplete(int lst) if (undoing) setlastline(); - if (!module_loaded("zsh/complete")) + /* From the C-code's point of view, we can only use compctl as a default + * type of completion. Load it if it hasn't been loaded already and + * no completion widgets are defined. */ + + if (!module_loaded("zsh/compctl") && !hascompwidgets) load_module("zsh/compctl"); if (runhookdef(BEFORECOMPLETEHOOK, (void *) &lst)) { -- cgit 1.4.1