From fa633171fd280096280628887947eb6a0dac3de7 Mon Sep 17 00:00:00 2001 From: Peter Stephenson Date: Tue, 10 Jan 2006 16:57:02 +0000 Subject: 22151: bug outputting here-strings from which etc. when already quoted --- ChangeLog | 5 +++++ Src/text.c | 21 +++++++++++---------- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index ab30d8226..917fbb16e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-01-10 Peter Stephenson + + * 22151: Src/text.c: a here-string got too many quotes when + output by which etc. + 2006-01-09 Wayne Davison * unposted: Src/utils.c, Src/Zle/compmatch.c, Src/Zle/zle_utils.c: diff --git a/Src/text.c b/Src/text.c index ceb4bfdf4..db24d8c9e 100644 --- a/Src/text.c +++ b/Src/text.c @@ -798,16 +798,17 @@ getredirs(LinkList redirs) taddstr(fstr[f->type]); if (f->type != REDIR_MERGEIN && f->type != REDIR_MERGEOUT) taddchr(' '); - if (f->type == REDIR_HERESTR) { - if (has_token(f->name)) { - taddchr('\"'); - taddstr(bslashquote(f->name, NULL, 2)); - taddchr('\"'); - } else { - taddchr('\''); - taddstr(bslashquote(f->name, NULL, 1)); - taddchr('\''); - } + if (f->type == REDIR_HERESTR && !has_token(f->name)) { + /* + * Strings that came from here-documents are converted + * to here strings without quotation, so add that + * now. If tokens are already present taddstr() + * will do the right thing (anyway, adding more + * quotes certainly isn't right in that case). + */ + taddchr('\''); + taddstr(bslashquote(f->name, NULL, 1)); + taddchr('\''); } else taddstr(f->name); taddchr(' '); -- cgit 1.4.1