From ca6f4466e661f185d083e09c55fb93d16e0736cc Mon Sep 17 00:00:00 2001 From: Daniel Shahaf Date: Sun, 22 Dec 2019 04:52:38 +0000 Subject: 45131: Make a function that redefines itself preserve its tracedness. This makes it easy to apply local tracing ('functions -T') to autoloadable functions that redefines themselves when first loaded. --- ChangeLog | 5 +++++ Src/exec.c | 6 ++++++ Test/E02xtrace.ztst | 9 +++++++++ 3 files changed, 20 insertions(+) diff --git a/ChangeLog b/ChangeLog index 3b82468c7..a9bf59c5b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2019-12-26 Daniel Shahaf + + * 45131: Src/exec.c, Test/E02xtrace.ztst: Make a function that + redefines itself preserve its tracedness. + 2019-12-23 Daniel Shahaf * unposted: Completion/Unix/Command/_stdbuf: Fix mismatch diff --git a/Src/exec.c b/Src/exec.c index fac095d64..356e2974b 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -5320,6 +5320,12 @@ execfuncdef(Estate state, Eprog redir_prog) */ removetrapnode(signum); } + /* Is this function traced and redefining itself? */ + if (funcstack && funcstack->tp == FS_FUNC && + !strcmp(s, funcstack->name)) { + Shfunc old = ((Shfunc)shfunctab->getnode(shfunctab, s)); + shf->node.flags |= old->node.flags & (PM_TAGGED|PM_TAGGED_LOCAL); + } shfunctab->addnode(shfunctab, ztrdup(s), shf); } } diff --git a/Test/E02xtrace.ztst b/Test/E02xtrace.ztst index da6191cd0..8d2c300cf 100644 --- a/Test/E02xtrace.ztst +++ b/Test/E02xtrace.ztst @@ -146,3 +146,12 @@ ?+(anon):0> '(anon)' ?+(anon):0> true ?+fn:0> gn + + f() { + f() { echo inner } + } + functions -T f + f + which f | grep '# traced' +0:a function that redefines itself preserves tracing +> # traced -- cgit 1.4.1