From a8cc017c74a916b690dc074c299faf4bd24b5af4 Mon Sep 17 00:00:00 2001 From: Kamil Dudka Date: Wed, 7 Nov 2018 14:04:52 +0100 Subject: 43791: File descriptor could be closed twice in clone --- ChangeLog | 4 ++++ Src/Modules/clone.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 72a74849e..97751c16e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2018-11-09 Peter Stephenson + + * 43791: Kamil: Src/Modules/clone.c: file descriptor was closed twice. + 2018-11-08 Oliver Kiddle * 43779 (tweaked): Joey Pabalinas: Functions/Zle/select-bracketed: diff --git a/Src/Modules/clone.c b/Src/Modules/clone.c index ef6275dcf..4b2655505 100644 --- a/Src/Modules/clone.c +++ b/Src/Modules/clone.c @@ -96,7 +96,8 @@ bin_clone(char *nam, char **args, UNUSED(Options ops), UNUSED(int func)) init_io(NULL); setsparam("TTY", ztrdup(ttystrname)); } - close(ttyfd); + else + close(ttyfd); if (pid < 0) { zerrnam(nam, "fork failed: %e", errno); return 1; -- cgit 1.4.1