From 517cda383217ae4c68c5782429a5dbc4962b407a Mon Sep 17 00:00:00 2001 From: "Barton E. Schaefer" Date: Sun, 15 Apr 2018 10:56:35 -0700 Subject: 42636: fix GLOB_DOTS for !(RM_STAR_SILENT) Also fix paste-o in older log entry --- ChangeLog | 6 +++++- Src/utils.c | 9 +++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 72b1ebaad..388d052c8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2018-04-15 Barton E. Schaefer + + * 42636: Src/utils.c: fix GLOB_DOTS for !(RM_STAR_SILENT) + 2018-04-13 Daniel Hahler * 42631: Completion/Unix/Command/_pgrep: _pgrep: pkill: fix completion @@ -206,7 +210,7 @@ * 42487: Src/Zle/compctl.c: remove gcc 7.3.0 warnings and potentially incorrect pointer usage. -2018-03-18 Barton E. Schaefer +2018-03-18 Barton E. Schaefer * Stephane: 42469: Src/exec.c, Src/Modules/mapfile.c: fix 42465 diff --git a/Src/utils.c b/Src/utils.c index 180693d67..cb292a050 100644 --- a/Src/utils.c +++ b/Src/utils.c @@ -2775,10 +2775,11 @@ checkrmall(char *s) const int max_count = 100; if ((rmd = opendir(unmeta(s)))) { int ignoredots = !isset(GLOBDOTS); - /* ### TODO: Passing ignoredots here is wrong. See workers/41672 - aka . - */ - while (zreaddir(rmd, ignoredots)) { + char *fname; + + while (fname = zreaddir(rmd, 1)) { + if (ignoredots && *fname == '.') + continue; count++; if (count > max_count) break; -- cgit 1.4.1