From 4044d73706a4779d145bc27512a434865b081f28 Mon Sep 17 00:00:00 2001 From: Oliver Kiddle Date: Sat, 7 Apr 2018 12:52:54 +0200 Subject: 42600: error paths for _values leaked the exclusion list array --- ChangeLog | 3 +++ Src/Zle/computil.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index 49c8a681f..60ec155d7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2018-04-07 Oliver Kiddle + * 42600: Src/Zle/computil.c: error paths for _values leaked + the exclusion list array + * 42597: Src/params.c: plug memory leak found by coverity * 42595: Src/utils.c: remove dead code flagged by coverity diff --git a/Src/Zle/computil.c b/Src/Zle/computil.c index 2e86e5740..5526e0ad0 100644 --- a/Src/Zle/computil.c +++ b/Src/Zle/computil.c @@ -3022,6 +3022,7 @@ parse_cvdef(char *nam, char **args) if (hassep && !sep && name + bs + 1 < p) { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "no multi-letter values with empty separator allowed"); return NULL; } @@ -3035,6 +3036,7 @@ parse_cvdef(char *nam, char **args) if (!*p) { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "invalid value definition: %s", *args); return NULL; } @@ -3046,6 +3048,7 @@ parse_cvdef(char *nam, char **args) } if (c && c != ':') { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "invalid value definition: %s", *args); return NULL; } @@ -3054,6 +3057,7 @@ parse_cvdef(char *nam, char **args) if (c == ':') { if (hassep && !sep) { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "no value with argument with empty separator allowed"); return NULL; } -- cgit 1.4.1