From 1507719d0a5c8ff8694583fbc4c993e937fb9266 Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Mon, 5 Jan 2015 16:08:56 +0100 Subject: 34112: typeset: fix leak of oldval Found by Coverity (Issue 1255803). --- ChangeLog | 2 ++ Src/builtin.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ChangeLog b/ChangeLog index 321d9fc1d..2afb52cc2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2015-01-06 Mikael Magnusson + * 34112: Src/builtin.c: typeset: fix leak of oldval + * 34106: Src/hist.c: use zhtricat instead of tricat * 34113: Src/builtin.c: whence: use dupstring to not leak memory diff --git a/Src/builtin.c b/Src/builtin.c index 228eaaada..5138c70fd 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -2510,6 +2510,8 @@ bin_typeset(char *name, char **argv, Options ops, int func) asg->name), func, (on | PM_ARRAY) & ~PM_EXPORTED, off, roff, asg->value, NULL, ops, 0))) { + if (oldval) + zsfree(oldval); unqueue_signals(); return 1; } -- cgit 1.4.1