summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* 45424: completion: Add **/sbin to PATH when completing commands like sudodana2020-03-116-22/+57
| | | | | | | | | | | | | | | | | | * Update _command_names to add **/sbin to PATH when not otherwise overridden and _comp_priv_prefix is set. This ensures that, on systems where unprivileged users don't have **/sbin in their PATHs, we can still complete those commands when they try to run them with e.g. sudo * Update functions for privilege-gaining commands to use the aforementioned mechanism * Fix some other minor issues in _pfexec and _doas Changes from the posted diff: * Fix a minor redundancy in _doas * Add _c_p_p=( '' ) hack to _su
* 45524: Add completion for dscverify(1) from Debian's devscripts.Romain Porte2020-03-102-0/+35
|
* 45518 + unposted tweak (change single quotes to double quotes): Fix ↵Daniel Shahaf2020-03-092-14/+25
| | | | V01zmotload.ztst test failures when zsh/parameter is dynamically linked (which is the default).
* Merge remote-tracking branch 'origin/5.9'Daniel Shahaf2020-03-0713-44/+303
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * origin/5.9: unposted: Move a new incompatibility notice. unposted: Fix trailing whitespace in test expectations. 45342: Add tests for interaction between autoloadable parameters and module loading. 45313: _git: Support completion from outside of a worktree when --git-dir/--work-tree are specified on the command line 45304: Do execute the always block even when the try/always block itself is the last command. 45292: D02glob: Add regression test for macOS stat(2) misbehaviour 45291: A glob with a trailing slash will now match unreadable/unexecutable directories. 45288: _git: Complete bisect/new as well as bisect/bad. 45246: Make --disable-multibyte warn, since the test suite fails in that configuration. 45213: Make --enable-gdbm default to false, rather than default to true with an unavoidable warning. unposted (follow-up to 45131): Extra testing by Mikael 45137: zformat: Allow the specifying minimum width and a dot with an empty maximum width. 45138: Add zformat unit tests. 45131: Make a function that redefines itself preserve its tracedness.
| * unposted: Move a new incompatibility notice. 5.9Daniel Shahaf2020-03-072-2/+7
| | | | | | | | | | | | The change in question was (deliberately) not merged to master before the 5.8 release. Therefore, it is a "post 5.8" change, even though it was written when 5.7.1 was the latest release.
| * Merge remote-tracking branch 'origin/master' into 5.9Daniel Shahaf2020-03-0750-675/+1287
| |\ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Test/D02glob.ztst: On the "unreadable directories can be globbed (users/24619, users/24626)" test, resolve conflicts by removing the Cygwin-only skip that has been added in master, since the test is passing on this branch. This effectively reverts workers/45492. See discussion starting in workers/45504. * origin/master: unposted: Remove 'sgi', as that OpenBSD port has been discontinued. 45509: fix typos in B01cd.ztst 45490 (+45495 and a test): refactor rlimits.c github #49: Fix typo: longson should be loongson users/24710: Fix job control problem with sudo. 45492: skip test added by users/24633 on Cygwin 45488: COMP_WORDS for bash need "$@"-style quoting 45487: Missing mod_export declarations for AIX 45447: Complete vcs_info_hookadd and vcs_info_hookdel. Expose _vcs_info_hooks as a top-level helper function. 45463: test: kill: Document why we use SIGURG 45453: builtins: kill: Do not signal current process group when pid is empty 45452: builtins: kill: Add `kill ''` regression test with explicit sigspec 45451: builtins: kill: Add basic test suite github #48/0002: vcs_info git: properly detect bare repositories github #48/0001: vcs_info git: avoid warnings in bare repositories unposted: Post-release version bump unposted: Release 5.8 CVE-2019-20044: Update change log for preceding commits Update NEWS/README Add unsetopt/PRIVILEGED tests Clean up error-message white space Improve PRIVILEGED fixes (again) Improve PRIVILEGED fixes Drop privileges securely unposted: V01zmodload: Fix failing test from workers/45385 45423: _su: Improve arg handling, shell look-ups unposted: _zip: Recognise '--' 45385: Add a test for 'zmodload -Fa' preemptively disabling ("blacklisting"?) features. unposted: Test release: 5.7.1-test-3 zsh/system: Fix infinite loop in sysread _diff_options: Restore -w completion lost in workers/43351 unposted: Fix ChangeLog typo. 45368: Add tests for workers/45367's issue about double slashes in 'cd -P' and /home/daniel/in/zsh. 45373: Fix ERR_EXIT bug in else branch of if. 45372: Record a symlink loop bug involving :P 45365: _git: Fix __git_recent_branches for the case when a commit has an empty message 45343: Queue signals around arithmetic evaluations 45344: Document where third-party completion functions should be installed. 45345: internal: ztst.vim: Fix highlighting of zsh comments in test payload unposted: internal: Add some comments and fix indentation. No functional change. 45340: internal: Document the difference between paramtab and realparamtab. 45332: _git: add completion for git-version _brace_parameter: add missing \ Conflicts: ChangeLog Test/D02glob.ztst Test/V01zmodload.ztst
* | unposted: Remove 'sgi', as that OpenBSD port has been discontinued.Daniel Shahaf2020-03-062-1/+6
| | | | | | | | See https://www.openbsd.org/sgi.html and discussion on github PR #49.
* | 45509: fix typos in B01cd.ztstJun-ichi Takimoto2020-03-062-3/+5
| |
* | 45490 (+45495 and a test): refactor rlimits.cJun-ichi Takimoto2020-03-067-561/+281
| | | | | | | | | | Use a table of known resouces instead of generating rlimits.h by rlimits.awk.
* | github #49: Fix typo: longson should be loongsonBryan Irvine2020-03-052-1/+6
| |
* | users/24710: Fix job control problem with sudo.Peter Stephenson2020-02-274-6/+21
| | | | | | | | | | | | | | If we use kill to test for continued existence of a process group, we should check on failure that the error is ESRCH, as EPERM indicates the group still has memebers but running privileged so should be left alone.
* | 45492: skip test added by users/24633 on CygwinJun-ichi Takimoto2020-02-272-5/+14
| |
* | 45488: COMP_WORDS for bash need "$@"-style quotingMarc2020-02-252-1/+6
| |
* | 45487: Missing mod_export declarations for AIXPeter Stephenson2020-02-247-6/+12
| |
* | 45447: Complete vcs_info_hookadd and vcs_info_hookdel. Expose ↵Daniel Shahaf2020-02-194-3/+41
| | | | | | | | _vcs_info_hooks as a top-level helper function.
* | 45463: test: kill: Document why we use SIGURGChris Down2020-02-182-0/+12
| | | | | | | | See discussion in workers/45460.
* | 45453: builtins: kill: Do not signal current process group when pid is emptyChris Down2020-02-183-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following case was encountered in the wild: % zsh; echo "$?" % trap 'exit 5' TERM % kill '' 5 This behaviour seems more likely to be the result of bugs in programs (e.g. `kill -9 "$unsetvar") rather than being desirable behaviour to me. It also seems unintentional judging by the code and documentation, since it comes about as a result of the fact that: - `isanum` returns true for empty strings (since an empty string technically only consists of digits and minuses...); - `atoi`, when passed a pointer to an invalid number, returns 0; - `kill(0, signal)` sends the signal in question to all processes in the current process group. There are (at least) two ways to solve this issue: 1. Add special handling to `kill` to avoid this case. See this patch[0] for a version that does that. 2. Change how isanum behaves. Since the only two call sites that use it both seem like they should handle the case where the input char array is empty, that seems like a reasonable overall change to me.[1] After this patch: % trap 'exit 5' TERM % kill '' kill: illegal pid: The regression test for `kill` without a sigspec is also included in this commit, as previously it's not possible to test it trivially as it would still kill the test runner in expected-to-fail mode; see discussion in workers/45449. 0: workers/45426: https://www.zsh.org/mla/workers/2020/msg00251.html 1: The other call site using isanum() is the fg builtin, but in that case we just fail later since we can't find any job named '', so no big deal either way. It's the kill case which is more concerning.
* | 45452: builtins: kill: Add `kill ''` regression test with explicit sigspecChris Down2020-02-182-0/+12
| | | | | | | | | | | | | | | | The version without a sigspec can't be added yet because it would still kill the test runner even in expected-to-fail mode; see workers/45449 for discussion. For the same reason, we use a signal which is non-fatal by default and unlikely to be sent by someone else, SIGURG, to do the expected-to-fail case prior to the fix.
* | 45451: builtins: kill: Add basic test suiteChris Down2020-02-182-0/+64
| | | | | | | | | | | | This is not totally comprehensive, but at least it's a start for the core functionality. In the next commits, we'll also use this base to add some regression tests.
* | github #48/0002: vcs_info git: properly detect bare repositoriesbrian m. carlson2020-02-172-0/+8
| | | | | | | | | | | | | | | | | | | | | | We currently detect Git repositories by finding the top level of the working tree, and if we fail to detect it, assume that we're not in a repository. However, there's a case we don't consider: a bare repository. Let's detect if the user is in a bare repository by checking if gitdir is set, and if so, using that if there is no working tree. We now detect bare Git repositories with vcs_info, as expected.
* | github #48/0001: vcs_info git: avoid warnings in bare repositoriesbrian m. carlson2020-02-172-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | Git 2.25 introduced a change to how git rev-parse --show-toplevel behaves. Traditionally, it succeeded with no output if the user was in a bare repository. Now it dies, printing an error to standard error. Consequently, when the user is in a bare repository with a newer Git, vcs_info prints noisily to standard error. While this is functionally harmless, it is annoying for the shell to print messages from Git every time the prompt is printed, so let's silence the error message.
* | unposted: Post-release version bumpdana2020-02-142-2/+4
| |
* | unposted: Release 5.8 zsh-5.8dana2020-02-142-2/+4
| |
* | CVE-2019-20044: Update change log for preceding commitsdana2020-02-141-0/+6
| |
* | Update NEWS/READMEdana2020-02-142-4/+25
| |
* | Add unsetopt/PRIVILEGED testsdana2020-02-143-1/+207
| |
* | Clean up error-message white spacedana2020-02-141-9/+21
| |
* | Improve PRIVILEGED fixes (again)dana2020-02-141-49/+43
| | | | | | | | | | | | | | | | * Pass RGID instead of passwd GID to initgroups() * Clean up #ifdefs, avoid unnecessary checks * Flatten conditions
* | Improve PRIVILEGED fixesDaniel Shahaf2020-02-146-102/+292
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fix retval handling in bin_setopt() - Don't skip_setuid / skip_setgid. It's not our place to optimize away noops (that might not even _be_ noops; they might change the saved uid…). - Remove HAVE_* guard checks around functions that are used unguarded elsewhere. - Use bsd-setres_id.c from OpenSSH to provide setresuid() / setresgid() everywhere, and thus simplify the ifdef soup. Fix some preëxisting bugs in the macro definitions of setuid() (do we still need that one?). - Fix zwarning() format codes for variadic arguments type safety - Restored a comment from HEAD - Fix failure modes around initgroups() - Compared privilege restoration code with OpenSSH's permanently_drop_uid() and updated as needed - Add E01 PRIVILEGED sanity checks
* | Drop privileges securelySam Foxman2020-02-142-41/+124
| |
* | unposted: V01zmodload: Fix failing test from workers/45385dana2020-02-142-2/+7
| |
* | 45423: _su: Improve arg handling, shell look-upsdana2020-02-142-12/+38
| | | | | | | | | | | | | | | | Differences from ML post: * Properly fix escaping issue with $usr (needs unescaped first) * Make $shell emptiness check easier to read (per feedback)
* | unposted: _zip: Recognise '--'dana2020-02-072-3/+7
| |
* | 45385: Add a test for 'zmodload -Fa' preemptively disabling ↵Daniel Shahaf2020-02-072-0/+19
| | | | | | | | ("blacklisting"?) features.
* | unposted: Test release: 5.7.1-test-3 zsh-5.7.1-test-3dana2020-02-062-2/+4
| |
* | zsh/system: Fix infinite loop in sysreadRoman Perepelitsa2020-02-062-1/+4
| |
* | _diff_options: Restore -w completion lost in workers/43351Martin von Wittich2020-02-062-0/+7
| |
* | unposted: Fix ChangeLog typo.Daniel Shahaf2020-02-061-1/+1
| |
* | 45368: Add tests for workers/45367's issue about double slashes in 'cd -P' ↵Daniel Shahaf2020-02-033-0/+14
| | | | | | | | and /home/daniel/in/zsh.
* | 45373: Fix ERR_EXIT bug in else branch of if.Peter Stephenson2020-02-023-1/+15
| | | | | | | | | | The flags need resetting for this branch otherwise e.g. command substitution with non-zero status doesn't cause exit.
* | 45372: Record a symlink loop bug involving :PDaniel Shahaf2020-02-022-0/+6
| |
* | 45365: _git: Fix __git_recent_branches for the case when a commit has an ↵WGH2020-02-022-2/+7
| | | | | | | | empty message
* | 45343: Queue signals around arithmetic evaluationsDaniel Shahaf2020-01-293-7/+14
| | | | | | | | | | The queueing added in execarith() in 45083 is reverted since the callee does this now.
* | 45344: Document where third-party completion functions should be installed.Daniel Shahaf2020-01-292-0/+15
| |
* | 45345: internal: ztst.vim: Fix highlighting of zsh comments in test payloadDaniel Shahaf2020-01-282-1/+12
| |
* | unposted: internal: Add some comments and fix indentation. No functional ↵Daniel Shahaf2020-01-262-2/+18
| | | | | | | | change.
* | 45340: internal: Document the difference between paramtab and realparamtab.Daniel Shahaf2020-01-232-1/+12
| |
* | 45332: _git: add completion for git-versionEitan Adler2020-01-192-1/+17
| | | | | | | | Signed-off-by: Eitan Adler <lists@eitanadler.com>
* | _brace_parameter: add missing \Mikael Magnusson2020-01-191-1/+1
| |
| * unposted: Fix trailing whitespace in test expectations.Daniel Shahaf2020-03-072-3/+8
| |
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-09 09:56:21 +0000