diff options
author | Mikael Magnusson <mikachu@gmail.com> | 2015-01-05 14:00:01 +0100 |
---|---|---|
committer | Mikael Magnusson <mikachu@gmail.com> | 2015-01-06 23:51:01 +0100 |
commit | 38dc59907b50f1717b3634ab3a99499a52819e3f (patch) | |
tree | 38947ce522dd2ee02a85b64d51480d150c95ae87 /Src | |
parent | c425cc9632fc475e3117cf96e69e2510be5d80c0 (diff) | |
download | zsh-38dc59907b50f1717b3634ab3a99499a52819e3f.tar.gz zsh-38dc59907b50f1717b3634ab3a99499a52819e3f.tar.xz zsh-38dc59907b50f1717b3634ab3a99499a52819e3f.zip |
34120: compctl, jobs: Check contents instead of array
text is an array in the struct, and can never be null. Found by Coverity (Issue 1255780).
Diffstat (limited to 'Src')
-rw-r--r-- | Src/Zle/compctl.c | 2 | ||||
-rw-r--r-- | Src/jobs.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/Src/Zle/compctl.c b/Src/Zle/compctl.c index 96ad6a280..2a80e6c84 100644 --- a/Src/Zle/compctl.c +++ b/Src/Zle/compctl.c @@ -3685,7 +3685,7 @@ makecomplistflags(Compctl cc, char *s, int incmd, int compadd) for (i = 0; i <= maxjob; i++) if ((jobtab[i].stat & STAT_INUSE) && - jobtab[i].procs && jobtab[i].procs->text) { + jobtab[i].procs && jobtab[i].procs->text[0]) { int stopped = jobtab[i].stat & STAT_STOPPED; j = dupstring(jobtab[i].procs->text); diff --git a/Src/jobs.c b/Src/jobs.c index c6e1bce15..295f4c939 100644 --- a/Src/jobs.c +++ b/Src/jobs.c @@ -2718,7 +2718,7 @@ findjobnam(const char *s) for (jobnum = maxjob; jobnum >= 0; jobnum--) if (!(jobtab[jobnum].stat & (STAT_SUBJOB | STAT_NOPRINT)) && jobtab[jobnum].stat && jobtab[jobnum].procs && jobnum != thisjob && - jobtab[jobnum].procs->text && strpfx(s, jobtab[jobnum].procs->text)) + jobtab[jobnum].procs->text[0] && strpfx(s, jobtab[jobnum].procs->text)) return jobnum; return -1; } |