about summary refs log tree commit diff
path: root/Src/params.c
diff options
context:
space:
mode:
authorPeter Stephenson <pws@zsh.org>2016-09-30 10:40:27 +0100
committerPeter Stephenson <pws@zsh.org>2016-09-30 10:41:44 +0100
commitd08674ef8c8e4920c2ebfa02f0bef86812f051ee (patch)
tree933c87d39a7608eb79064f0aa73af98f0b0a8bb3 /Src/params.c
parent5cf2ffb327faf84b73beb812ff2f7e9bf08e7ecf (diff)
downloadzsh-d08674ef8c8e4920c2ebfa02f0bef86812f051ee.tar.gz
zsh-d08674ef8c8e4920c2ebfa02f0bef86812f051ee.tar.xz
zsh-d08674ef8c8e4920c2ebfa02f0bef86812f051ee.zip
39498: use PRIVILEGED option to decide on problematic parameter imports
Diffstat (limited to 'Src/params.c')
-rw-r--r--Src/params.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/Src/params.c b/Src/params.c
index 87586a209..8271a8b53 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -333,7 +333,7 @@ IPDEF6("TRY_BLOCK_ERROR", &try_errflag, varinteger_gsu),
 IPDEF6("TRY_BLOCK_INTERRUPT", &try_interrupt, varinteger_gsu),
 
 #define IPDEF7(A,B) {{NULL,A,PM_SCALAR|PM_SPECIAL},BR((void *)B),GSU(varscalar_gsu),0,0,NULL,NULL,NULL,0}
-#define IPDEF7R(A,B) {{NULL,A,PM_SCALAR|PM_SPECIAL|PM_DONTIMPORT_ROOT},BR((void *)B),GSU(varscalar_gsu),0,0,NULL,NULL,NULL,0}
+#define IPDEF7R(A,B) {{NULL,A,PM_SCALAR|PM_SPECIAL|PM_DONTIMPORT_SUID},BR((void *)B),GSU(varscalar_gsu),0,0,NULL,NULL,NULL,0}
 #define IPDEF7U(A,B) {{NULL,A,PM_SCALAR|PM_SPECIAL|PM_UNSET},BR((void *)B),GSU(varscalar_gsu),0,0,NULL,NULL,NULL,0}
 IPDEF7("OPTARG", &zoptarg),
 IPDEF7("NULLCMD", &nullcmd),
@@ -705,8 +705,8 @@ static int dontimport(int flags)
     /* If value already exported */
     if (flags & PM_EXPORTED)
 	return 1;
-    /* If security issue when exporting as root */
-    if ((flags & PM_DONTIMPORT_ROOT) && (!getuid() || !geteuid()))
+    /* If security issue when importing and running with some privilege */
+    if ((flags & PM_DONTIMPORT_SUID) && isset(PRIVILEGED))
 	return 1;
     /* OK to import */
     return 0;