summary refs log tree commit diff
path: root/Src/params.c
diff options
context:
space:
mode:
authorPeter Stephenson <pws@zsh.org>2016-01-15 12:15:32 +0000
committerPeter Stephenson <pws@zsh.org>2016-01-15 12:16:40 +0000
commitda71967273150c318c8cb7dc9fb2c51d11adb827 (patch)
tree5a1fba492d0ff371b91a71dcecfb1dfc9f2d569d /Src/params.c
parent69379369daf5a159f7ac34a33778668d8d516848 (diff)
downloadzsh-da71967273150c318c8cb7dc9fb2c51d11adb827.tar.gz
zsh-da71967273150c318c8cb7dc9fb2c51d11adb827.tar.xz
zsh-da71967273150c318c8cb7dc9fb2c51d11adb827.zip
37512: overeager WARN_CREATE_GLOBAL with strftime
Diffstat (limited to 'Src/params.c')
-rw-r--r--Src/params.c16
1 files changed, 2 insertions, 14 deletions
diff --git a/Src/params.c b/Src/params.c
index 054fb1f54..b2e889738 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -2705,30 +2705,18 @@ static void
 check_warn_create(Param pm, const char *pmtype)
 {
     Funcstack i;
-    const char *name;
 
     if (pm->level != 0 || (pm->node.flags & PM_SPECIAL))
 	return;
 
-    name = NULL;
     for (i = funcstack; i; i = i->prev) {
 	if (i->tp == FS_FUNC) {
 	    DPUTS(!i->name, "funcstack entry with no name");
-	    name = i->name;
+	    zwarn("%s parameter %s created globally in function %s",
+		  pmtype, pm->node.nam, i->name);
 	    break;
 	}
     }
-
-    if (name)
-    {
-	zwarn("%s parameter %s created globally in function %s",
-	      pmtype, pm->node.nam, name);
-    }
-    else
-    {
-	zwarn("%s parameter %s created globally in function",
-	      pmtype, pm->node.nam);
-    }
 }
 
 /**/