diff options
author | Daniel Shahaf <d.s@daniel.shahaf.name> | 2020-08-28 02:36:35 +0000 |
---|---|---|
committer | Daniel Shahaf <d.s@daniel.shahaf.name> | 2020-08-28 02:54:51 +0000 |
commit | c6a85163619ed1cee89ab047a0d98108ed46828d (patch) | |
tree | 971de5921b534516c3f3545dc0474d6968dac181 /NEWS | |
parent | 5668cace4a2b821b59a5b3ad9daa1049b0ef95e0 (diff) | |
download | zsh-c6a85163619ed1cee89ab047a0d98108ed46828d.tar.gz zsh-c6a85163619ed1cee89ab047a0d98108ed46828d.tar.xz zsh-c6a85163619ed1cee89ab047a0d98108ed46828d.zip |
github #64: Fix a build-time error when building against ncurses that hadn't been built with --enable-wgetch-events.
The --enable-wgetch-events codepath is experimental (according to ncurses-6.2/INSTALL) and off by default (according to ncurses-6.2/configure.in). With that codepath disabled, the macro KEY_EVENT is not provided, which (before this commit) manifested as a build-time error: [ 245s] gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I. -DHAVE_CONFIG_H -DMODULE -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -fPIE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -I/usr/include/ncursesw -fPIC -o curses..o curses.c [ 246s] In file included from curses.c:210: [ 246s] curses_keys.h:93:15: error: 'KEY_EVENT' undeclared here (not in a function); did you mean 'KEY_RESET'? [ 246s] 93 | {"EVENT", KEY_EVENT}, [ 246s] | ^~~~~~~~~ [ 246s] | KEY_RESET curses_keys.h is only used for setting the "kevent" output parameter of 'zcurses input' (and the associated $zcurses_keycodes special variable), so there's no harm in just leaving KEY_EVENT out of it. (That codepath deals gracefully with numeric values that don't correspond to any of the known compile-time values, as that can happen whenever the build- and run-time versions of ncurses don't provide the same set of KEY_* macros, with or without relation to that configure flag.) Reported by Martin Liska.
Diffstat (limited to 'NEWS')
0 files changed, 0 insertions, 0 deletions