summary refs log tree commit diff
path: root/Completion/Unix
diff options
context:
space:
mode:
authorEric Cook <llua@gmx.com>2015-08-13 16:10:35 +0200
committerOliver Kiddle <opk@zsh.org>2015-08-13 16:10:35 +0200
commitf158e5c4cf7480447f3a4837f729e4dfeedd3317 (patch)
treed94807df0345be187402fb422e5152f4fd98a2dc /Completion/Unix
parent8e0b5e0e009271a7a9fc371e7278e9d9de22cfb3 (diff)
downloadzsh-f158e5c4cf7480447f3a4837f729e4dfeedd3317.tar.gz
zsh-f158e5c4cf7480447f3a4837f729e4dfeedd3317.tar.xz
zsh-f158e5c4cf7480447f3a4837f729e4dfeedd3317.zip
36113: ip(8) may add suffixes which is not good for completion matches
Diffstat (limited to 'Completion/Unix')
-rw-r--r--Completion/Unix/Type/_find_net_interfaces19
1 files changed, 6 insertions, 13 deletions
diff --git a/Completion/Unix/Type/_find_net_interfaces b/Completion/Unix/Type/_find_net_interfaces
index 0c7033519..3f5db6b9a 100644
--- a/Completion/Unix/Type/_find_net_interfaces
+++ b/Completion/Unix/Type/_find_net_interfaces
@@ -21,22 +21,15 @@ case $OSTYPE in
   ;;
   darwin*|freebsd*|dragonfly*) net_intf_list=( $(ifconfig -l) ) ;;
   irix*) net_intf_list=( ${${${(f)"$(/usr/etc/netstat -i)"}%% *}[2,-1]} ) ;;
-  *linux*)
-    if (( $+commands[ip] )); then
-      net_intf_list=( ${${(m)${(f)"$(ip -o link)"}#*: }%%: *} )
-    fi
-  ;&
-
   *)
-  if [[ ${#net_intf_list} -eq 0 ]]; then
     # linux's deprecated ifconfig may truncate long interface names
-    net_intf_list=( $(ifconfig -a 2>/dev/null | sed -n 's/^\([^ 	:]*\).*/\1/p') )
-    if [[ -d /proc/sys/net/ipv4/conf ]]; then
-      # On linux we used to use the following as the default.
-      # However, we now use ip or ifconfig since it finds additional devices such
+    net_intf_list=( $(_call_program interfaces "ifconfig -a 2>/dev/null | sed -n 's/^\([^ 	:]*\).*/\1/p'") )
+    if (( ${#net_intf_list} == 0 )) && [[ -d /proc/sys/net/ipv4/conf ]]; then
+      # On linux we used to use the following as the default, without /sys/class/net/*.
+      # However, we now use ifconfig since it finds additional devices such
       # as tunnels.  So only do this if that didn't work.
-      net_intf_list=( /proc/sys/net/ipv4/conf/*~*(all|default)(N:t) )
+      typeset -gU net_intf_list
+      net_intf_list=( /proc/sys/net/ipv4/conf/*~*(all|default)(N:t) /sys/class/net/*(N:t) )
     fi
-  fi
   ;;
 esac