summary refs log tree commit diff
diff options
context:
space:
mode:
authorPeter Stephenson <pws@users.sourceforge.net>2008-07-01 18:38:39 +0000
committerPeter Stephenson <pws@users.sourceforge.net>2008-07-01 18:38:39 +0000
commit1a9386290b36ea4d500092f7f5b6a08367ec4886 (patch)
tree976a443691f900bf089046c1b17b9a35bf0fe886
parent7453337589f3500173b163b61d4ff4c478e0f8b8 (diff)
downloadzsh-1a9386290b36ea4d500092f7f5b6a08367ec4886.tar.gz
zsh-1a9386290b36ea4d500092f7f5b6a08367ec4886.tar.xz
zsh-1a9386290b36ea4d500092f7f5b6a08367ec4886.zip
25262: suspicious error checking in braceless function definition
-rw-r--r--ChangeLog5
-rw-r--r--Src/parse.c3
2 files changed, 6 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 34ddbac45..3a4b87970 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-07-01  Peter Stephenson  <p.w.stephenson@ntlworld.com>
+
+	* 25262: Src/parse.c: suspicious attempt to test errors
+	when parsing command within braceless function.
+
 2008-07-01  Peter Stephenson  <pws@csr.com>
 
 	* 25259: Src/utils.c: make getquery() handle unhandled characters
diff --git a/Src/parse.c b/Src/parse.c
index 54543a642..beb88b451 100644
--- a/Src/parse.c
+++ b/Src/parse.c
@@ -1687,8 +1687,7 @@ par_simple(int *complex, int nr)
 		sl = ecadd(0);
 		pl = ecadd(WCB_PIPE(WC_PIPE_END, 0));
 
-		par_cmd(&c);
-		if (!c) {
+		if (!par_cmd(&c)) {
 		    cmdpop();
 		    YYERROR(oecused);
 		}