diff options
| author | Mikael Magnusson <mikachu@gmail.com> | 2015-01-05 15:39:33 +0100 |
|---|---|---|
| committer | Mikael Magnusson <mikachu@gmail.com> | 2015-01-06 23:47:12 +0100 |
| commit | 5a9be691858ec25697234cefc5007a8c3fc95803 (patch) | |
| tree | 24e57233e04ace30385b1883f92b02028b8a6028 | |
| parent | 8035794a56eec3539fb1080ca3818237ed504349 (diff) | |
| download | zsh-5a9be691858ec25697234cefc5007a8c3fc95803.tar.gz zsh-5a9be691858ec25697234cefc5007a8c3fc95803.tar.xz zsh-5a9be691858ec25697234cefc5007a8c3fc95803.zip | |
34113: whence: use dupstring to not leak memory
All other assignments to buf use the heap, and it's never freed. Found by Coverity (Issue 1255786).
| -rw-r--r-- | ChangeLog | 2 | ||||
| -rw-r--r-- | Src/builtin.c | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog index 4f58df1fa..a000719c5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2015-01-06 Mikael Magnusson <mikachu@gmail.com> + * 34113: Src/builtin.c: whence: use dupstring to not leak memory + * 34119: Src/Zle/complist.c: Fix leak of string in clnicezputs * 34105: Src/subst.c: remove dead code diff --git a/Src/builtin.c b/Src/builtin.c index afa836a03..228eaaada 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -3323,7 +3323,7 @@ bin_whence(char *nam, char **argv, Options ops, int func) for (pp = path; *pp; pp++) { if (**pp) { buf = zhtricat(*pp, "/", *argv); - } else buf = ztrdup(*argv); + } else buf = dupstring(*argv); if (iscom(buf)) { if (wd) { |