diff options
| author | Sebastian Gniazdowski <psprint@fastmail.com> | 2016-11-08 08:05:05 -0800 |
|---|---|---|
| committer | Peter Stephenson <pws@zsh.org> | 2016-11-09 10:32:48 +0000 |
| commit | 49407686b47fed0e4810e0ba6127a9589c05b68b (patch) | |
| tree | 7f1dc89a00160c216f65babb8a9823c3a8d025a5 | |
| parent | d8786da0cd091fa44fd5b1f11ae90f070952f0c8 (diff) | |
| download | zsh-49407686b47fed0e4810e0ba6127a9589c05b68b.tar.gz zsh-49407686b47fed0e4810e0ba6127a9589c05b68b.tar.xz zsh-49407686b47fed0e4810e0ba6127a9589c05b68b.zip | |
39875: add dupstring_glen to avoid redundant strlen calls
| -rw-r--r-- | ChangeLog | 5 | ||||
| -rw-r--r-- | Src/params.c | 4 | ||||
| -rw-r--r-- | Src/string.c | 17 |
3 files changed, 24 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog index 272264163..416ecf114 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-11-09 Peter Stephenson <p.stephenson@samsung.com> + + * Sebastian: 39875: Src/params.c, Src/string.c: add + dupstring_glen() to avoid redundant strlen() calls. + 2016-11-09 Daniel Shahaf <d.s@daniel.shahaf.name> * 39853: Completion/Unix/Command/_subversion: Accept long diff --git a/Src/params.c b/Src/params.c index 19a8c291d..3f0179267 100644 --- a/Src/params.c +++ b/Src/params.c @@ -2432,8 +2432,8 @@ assignstrvalue(Value v, char *val, int flags) char *z, *x; int zlen; - z = dupstring(v->pm->gsu.s->getfn(v->pm)); - zlen = strlen(z); + z = dupstring_glen(v->pm->gsu.s->getfn(v->pm), (unsigned*) &zlen); + if ((v->flags & VALFLAG_INV) && unset(KSHARRAYS)) v->start--, v->end--; if (v->start < 0) { diff --git a/Src/string.c b/Src/string.c index b46ea60cf..a8da14fe0 100644 --- a/Src/string.c +++ b/Src/string.c @@ -41,6 +41,8 @@ dupstring(const char *s) return t; } +/* Duplicate string on heap when length is known */ + /**/ mod_export char * dupstring_wlen(const char *s, unsigned len) @@ -54,6 +56,21 @@ dupstring_wlen(const char *s, unsigned len) return t; } +/* Duplicate string on heap, returning length of string */ + +/**/ +mod_export char * +dupstring_glen(const char *s, unsigned *len_ret) +{ + char *t; + + if (!s) + return NULL; + t = (char *) zhalloc((*len_ret = strlen((char *)s)) + 1); + strcpy(t, s); + return t; +} + /**/ mod_export char * ztrdup(const char *s) |