about summary refs log tree commit diff
diff options
context:
space:
mode:
authorBart Schaefer <barts@users.sourceforge.net>2000-07-04 16:16:34 +0000
committerBart Schaefer <barts@users.sourceforge.net>2000-07-04 16:16:34 +0000
commite1fe756d146dbc5e739e867c89ab2c35aeac8de1 (patch)
treeaf8873281bef9bf73e8be51dc47946a384c9357a
parent708dc69d3830e0193f19032d0bd9f9df90772220 (diff)
downloadzsh-e1fe756d146dbc5e739e867c89ab2c35aeac8de1.tar.gz
zsh-e1fe756d146dbc5e739e867c89ab2c35aeac8de1.tar.xz
zsh-e1fe756d146dbc5e739e867c89ab2c35aeac8de1.zip
12160: Cause compdump to fail early if it won't be able to write the file.
-rw-r--r--ChangeLog15
-rw-r--r--Completion/Core/compdump2
2 files changed, 12 insertions, 5 deletions
diff --git a/ChangeLog b/ChangeLog
index eedfc1184..02ce7fcb8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2000-07-04  Bart Schaefer  <schaefer@zsh.org>
+
+	* 12160: Completion/Core/compdump: Return failure early if the
+	dot-file directory is not writable.
+
 2000-07-04  Oliver Kiddle  <opk@zsh.org>
 
 	* unposted: Src/params.c, Src/Zle/compcore.c, Src/Zle/zle_utils.c:
@@ -7,15 +12,15 @@
 
 	* 12158: Src/Modules/parameter.c: cast pid_t to int for printing.
 
-2000-07-03  Peter Stephenson  <pws@cambridgesiliconradio.com>
-
-	* 12149: acconfig.h, configure.in, Src/Modules/zftp.c:
-	h_errno wasn't found on HPUX 10.20.  Maybe in some library.
-
 2000-07-04  Sven Wischnowsky  <wischnow@zsh.org>
 
 	* 12156: Completion/Core/_expand, Completion/Core/_path_files: add
  	some $(print...)s because of possible math-parse errors
+
+2000-07-03  Peter Stephenson  <pws@cambridgesiliconradio.com>
+
+	* 12149: acconfig.h, configure.in, Src/Modules/zftp.c:
+	h_errno wasn't found on HPUX 10.20.  Maybe in some library.
 	
 2000-07-03  Adam Spiers  <adam@spiers.net>
 
diff --git a/Completion/Core/compdump b/Completion/Core/compdump
index de998bbd2..ba65d1501 100644
--- a/Completion/Core/compdump
+++ b/Completion/Core/compdump
@@ -21,6 +21,8 @@ typeset _d_file _d_f _d_bks _d_line _d_als _d_files
 _d_file=${_comp_dumpfile-${0:h}/compinit.dump}.$HOST.$$
 [[ $_d_file = //* ]] && _d_file=${_d_file[2,-1]}
 
+[[ -w ${_d_file:h} ]] || return 1
+
 _d_files=( ${^~fpath:/.}/^([^_]*|*~|*.zwc)(N) )
 
 if [[ -n "$_comp_secure" ]]; then