about summary refs log tree commit diff
diff options
context:
space:
mode:
authorPeter Stephenson <p.stephenson@samsung.com>2018-09-10 13:48:41 +0100
committerPeter Stephenson <p.stephenson@samsung.com>2018-09-10 13:48:41 +0100
commitd6859ce68e01cfa1d3c2e047bf4b25118152fdab (patch)
tree624bde4b26fdc4353f42129884d2a4b5f9af36df
parent943721abb9273c5751c4b19efe54aa7c3b2b49f1 (diff)
downloadzsh-d6859ce68e01cfa1d3c2e047bf4b25118152fdab.tar.gz
zsh-d6859ce68e01cfa1d3c2e047bf4b25118152fdab.tar.xz
zsh-d6859ce68e01cfa1d3c2e047bf4b25118152fdab.zip
43426: disable job control tests involving suspension.
These are provoking races on OpenSUSE.
-rw-r--r--ChangeLog5
-rw-r--r--Test/W02jobs.ztst70
2 files changed, 41 insertions, 34 deletions
diff --git a/ChangeLog b/ChangeLog
index 38472f10e..94d8338bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-10  Peter Stephenson  <p.stephenson@samsung.com>
+
+	* 43426: Test/W02jobs.ztst: disable tests involving suspending
+	jobs as these are provoking races in particular on OpenSUSE.
+
 2018-09-08  Daniel Shahaf  <d.s@daniel.shahaf.name>
 
 	* unposted: Etc/creating-a-release.txt: Add another step.
diff --git a/Test/W02jobs.ztst b/Test/W02jobs.ztst
index 1e7ac76c6..fe12f979d 100644
--- a/Test/W02jobs.ztst
+++ b/Test/W02jobs.ztst
@@ -85,27 +85,29 @@
 *>zsh:*running jobs*
 *>zsh:*SIGHUPed*
 
-  zpty_start
-  zpty_input 'setopt check_jobs no_check_running_jobs'
-  zpty_input 'sleep 3'
-  sleep 0.1
-  zpty_input $'\C-z'
-  zpty_stop
-0:suspended job with check_jobs + no_check_running_jobs
-*>zsh:*(stopped|suspended)*sleep*
-*>zsh:*(stopped|suspended) jobs*
-# no 'SIGHUPed' message for suspended jobs
-
-  zpty_start
-  zpty_input 'setopt check_jobs check_running_jobs'
-  zpty_input 'sleep 3'
-  sleep 0.1
-  zpty_input $'\C-z'
-  zpty_stop
-0:suspended job with check_jobs + check_running_jobs
-*>zsh:*(stopped|suspended)*sleep*
-*>zsh:*(stopped|suspended) jobs*
-# no 'SIGHUPed' message for suspended jobs
+#### Races presumed to be associated with zpty mean that
+#### tests involving suspending jobs are not safe.
+##   zpty_start
+##   zpty_input 'setopt check_jobs no_check_running_jobs'
+##   zpty_input 'sleep 3'
+##   sleep 0.1
+##   zpty_input $'\C-z'
+##   zpty_stop
+## 0:suspended job with check_jobs + no_check_running_jobs
+## *>zsh:*(stopped|suspended)*sleep*
+## *>zsh:*(stopped|suspended) jobs*
+## # no 'SIGHUPed' message for suspended jobs
+## 
+##   zpty_start
+##   zpty_input 'setopt check_jobs check_running_jobs'
+##   zpty_input 'sleep 3'
+##   sleep 0.1
+##   zpty_input $'\C-z'
+##   zpty_stop
+## 0:suspended job with check_jobs + check_running_jobs
+## *>zsh:*(stopped|suspended)*sleep*
+## *>zsh:*(stopped|suspended) jobs*
+## # no 'SIGHUPed' message for suspended jobs
 
   zpty_start
   zpty_input 'sleep 5 & sleep 4 & sleep 3 &'
@@ -153,19 +155,19 @@
 *>-
 *>zsh:*SIGHUPed*
 
-  zpty_start
-  zpty_input 'sleep 5'
-  sleep 0.1
-  zpty_input $'\C-z'
-  zpty_input 'jobs -r'
-  zpty_input 'print -- -'
-  zpty_input 'jobs -s'
-  zpty_stop
-0:`jobs -r` and `jobs -s` with suspended job
-*>zsh:*(stopped|suspended)*sleep*
-*>-
-*>\[1]  + (stopped|suspended)*sleep*
-# no 'SIGHUPed' message for suspended jobs
+##   zpty_start
+##   zpty_input 'sleep 5'
+##   sleep 0.1
+##   zpty_input $'\C-z'
+##   zpty_input 'jobs -r'
+##   zpty_input 'print -- -'
+##   zpty_input 'jobs -s'
+##   zpty_stop
+## 0:`jobs -r` and `jobs -s` with suspended job
+## *>zsh:*(stopped|suspended)*sleep*
+## *>-
+## *>\[1]  + (stopped|suspended)*sleep*
+## # no 'SIGHUPed' message for suspended jobs
 
   zpty_start
   zpty_input 'sleep 10 & sleep 9 & sleep 8 & sleep 7 &'