about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDaniel Shahaf <d.s@daniel.shahaf.name>2016-07-14 12:33:21 +0000
committerDaniel Shahaf <d.s@daniel.shahaf.name>2016-07-17 14:55:35 +0000
commitdb9f0d3b3e5f0211b50cdf422b99cffce8655d09 (patch)
treec820f67fba5827fcd5f549da7acb5576b1463c8f
parentd09cb7e979bc5186a8d322ef8977884371bbc462 (diff)
downloadzsh-db9f0d3b3e5f0211b50cdf422b99cffce8655d09.tar.gz
zsh-db9f0d3b3e5f0211b50cdf422b99cffce8655d09.tar.xz
zsh-db9f0d3b3e5f0211b50cdf422b99cffce8655d09.zip
unposted (cf. users/21737):: _git-subtree: Record technical debt in comment.
-rw-r--r--ChangeLog3
-rw-r--r--Completion/Unix/Command/_git4
2 files changed, 7 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index ebfe5b774..d8441b6b2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2016-07-17  Daniel Shahaf  <d.s@daniel.shahaf.name>
 
+	* unposted (cf. users/21737):: Completion/Unix/Command/_git:
+	_git-subtree: Record technical debt in comment.
+
 	* users/21750 (after users/21551): Completion/Unix/Command/_git:
 	_git-subtree: Tweak -m,-P completions
 
diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 98f06a3e2..5954c55e5 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -1784,6 +1784,10 @@ _git-subtree () {
             '--squash[import only a single commit from the subproject]' \
             ': :__git_any_repositories_or_references' \
             ':: :__git_ref_specs' && ret=0
+          # TODO: the use of __git_ref_specs isn't quite right: it will
+          # complete "foo:bar" values which git-subtree(1) doesn't take.  What
+          # we should complete here is what's on *one* side of the colon in
+          # __git_ref_specs.
 	;;
         (merge)
           _arguments -S \