about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDaniel Shahaf <d.s@daniel.shahaf.name>2017-09-21 18:17:02 +0000
committerDaniel Shahaf <d.s@daniel.shahaf.name>2017-09-21 18:17:19 +0000
commitced82745eace69a8bbe0f187d8caa7cb6347f50d (patch)
treeb7befa6045351610d79dd4267e9785fb51ba2f7e
parent15bed0db4085f51f223f7193eede41a112b71c82 (diff)
downloadzsh-ced82745eace69a8bbe0f187d8caa7cb6347f50d.tar.gz
zsh-ced82745eace69a8bbe0f187d8caa7cb6347f50d.tar.xz
zsh-ced82745eace69a8bbe0f187d8caa7cb6347f50d.zip
unposted (cf. 41672): checkrmall: Record the 41672 bug in a TODO.
-rw-r--r--ChangeLog3
-rw-r--r--Src/utils.c3
2 files changed, 6 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 3a0656fc6..000d5ccb3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2017-09-21  Daniel Shahaf  <d.s@daniel.shahaf.name>
 
+	* unposted (cf. 41672): Src/utils.c: checkrmall: Record the
+	41672 bug in a TODO.
+
 	* unposted (cf. 41707): Src/utils.c: internal: Document the
 	count==0 case of checkrmall().
 
diff --git a/Src/utils.c b/Src/utils.c
index 0d71dda09..4c0ebe6f5 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2709,6 +2709,9 @@ checkrmall(char *s)
     const int max_count = 100;
     if ((rmd = opendir(unmeta(s)))) {
 	int ignoredots = !isset(GLOBDOTS);
+	/* ### TODO: Passing ignoredots here is wrong.  See workers/41672
+	   aka <https://bugs.debian.org/875460>.
+	 */
 	while (zreaddir(rmd, ignoredots)) {
 	    count++;
 	    if (count > max_count)