summary refs log tree commit diff
diff options
context:
space:
mode:
authorJaime Marquínez Ferrándiz <jaime.marquinez.ferrandiz@gmail.com>2013-09-27 08:08:43 +0200
committerJaime Marquínez Ferrándiz <jaime.marquinez.ferrandiz@gmail.com>2013-09-27 08:08:43 +0200
commit74bab3f0a4b601a7618f279afbd352bbc51dc3ce (patch)
treee9396b02389a14acaee7be79ab27147be0d02d0e
parent85748629912aff950f8945b273e9809fc8991cfe (diff)
downloadyoutube-dl-74bab3f0a4b601a7618f279afbd352bbc51dc3ce.tar.gz
youtube-dl-74bab3f0a4b601a7618f279afbd352bbc51dc3ce.tar.xz
youtube-dl-74bab3f0a4b601a7618f279afbd352bbc51dc3ce.zip
Don't embed subtitles if the list is empty or the field is not set (fixes #1510)
-rw-r--r--youtube_dl/PostProcessor.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/youtube_dl/PostProcessor.py b/youtube_dl/PostProcessor.py
index ae56d2082..3ee1d3c58 100644
--- a/youtube_dl/PostProcessor.py
+++ b/youtube_dl/PostProcessor.py
@@ -444,8 +444,11 @@ class FFmpegEmbedSubtitlePP(FFmpegPostProcessor):
         if information['ext'] != u'mp4':
             self._downloader.to_screen(u'[ffmpeg] Subtitles can only be embedded in mp4 files')
             return True, information
-        sub_langs = [key for key in information['subtitles']]
+        if not information.get('subtitles'):
+            self._downloader.to_screen(u'[ffmpeg] There aren\'t any subtitles to embed') 
+            return True, information
 
+        sub_langs = [key for key in information['subtitles']]
         filename = information['filepath']
         input_files = [filename] + [subtitles_filename(filename, lang, self._subformat) for lang in sub_langs]