summary refs log tree commit diff
diff options
context:
space:
mode:
authorPhilipp Hagemeister <phihag@phihag.de>2013-08-28 12:04:44 +0200
committerPhilipp Hagemeister <phihag@phihag.de>2013-08-28 12:08:17 +0200
commitae3531adf926998d42d1fb52453491c85e33b5f0 (patch)
tree3185112c5cb7d688e77b43f73e6cfe0d3dabdad4
parent8cf5ee7831095a37ca5d223cca9e177f8768b84e (diff)
downloadyoutube-dl-ae3531adf926998d42d1fb52453491c85e33b5f0.tar.gz
youtube-dl-ae3531adf926998d42d1fb52453491c85e33b5f0.tar.xz
youtube-dl-ae3531adf926998d42d1fb52453491c85e33b5f0.zip
[generic] Fix URL concatenation
When the url is something like http://example.org/foo/bar?x=y  and the added is file/video.mp4 , we want http://example.org/foo/file/video.mp4
Fixes #1268.
-rw-r--r--youtube_dl/extractor/generic.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/youtube_dl/extractor/generic.py b/youtube_dl/extractor/generic.py
index d034a11bb..bfc9bff49 100644
--- a/youtube_dl/extractor/generic.py
+++ b/youtube_dl/extractor/generic.py
@@ -166,7 +166,12 @@ class GenericIE(InfoExtractor):
         if video_url.startswith('//'):
             video_url = compat_urllib_parse_urlparse(url).scheme + ':' + video_url
         if '://' not in video_url:
-            video_url = url + ('' if url.endswith('/') else '/') + video_url
+            up = compat_urllib_parse_urlparse(url)
+            if video_url.startswith('/'):
+                video_url = up.scheme + '://' + up.netloc + video_url
+            else:  # relative path
+                video_url = (up.scheme + '://' + up.netloc +
+                             up.path.rpartition('/')[0] + '/' + video_url)
         video_id = os.path.basename(video_url)
 
         # here's a fun little line of code for you: