From 0c05bd3a9c165cf2f0b9d6fa23a1f96532ddcdb3 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Thu, 6 Sep 2012 23:34:10 -0400 Subject: further use of _Noreturn, for non-plain-C functions note that POSIX does not specify these functions as _Noreturn, because POSIX is aligned with C99, not the new C11 standard. when POSIX is eventually updated to C11, it will almost surely give these functions the _Noreturn attribute. for now, the actual _Noreturn keyword is not used anyway when compiling with a c99 compiler, which is what POSIX requires; the GCC __attribute__ is used instead if it's available, however. in a few places, I've added infinite for loops at the end of _Noreturn functions to silence compiler warnings. presumably __buildin_unreachable could achieve the same thing, but it would only work on newer GCCs and would not be portable. the loops should have near-zero code size cost anyway. like the previous _Noreturn commit, this one is based on patches contributed by philomath. --- src/thread/pthread_create.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/thread') diff --git a/src/thread/pthread_create.c b/src/thread/pthread_create.c index 4567b41c..d8b8f0fc 100644 --- a/src/thread/pthread_create.c +++ b/src/thread/pthread_create.c @@ -8,7 +8,7 @@ weak_alias(dummy_0, __synccall_lock); weak_alias(dummy_0, __synccall_unlock); weak_alias(dummy_0, __pthread_tsd_run_dtors); -void pthread_exit(void *result) +_Noreturn void pthread_exit(void *result) { pthread_t self = pthread_self(); int n; @@ -43,7 +43,7 @@ void pthread_exit(void *result) __unmapself(self->map_base, self->map_size); } - __syscall(SYS_exit, 0); + for (;;) __syscall(SYS_exit, 0); } void __do_cleanup_push(struct __ptcb *cb) -- cgit 1.4.1