about summary refs log tree commit diff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* x32 port (diff against vanilla x86_64)rofl0r2014-02-2326-114/+120
|
* import vanilla x86_64 code as x32rofl0r2014-02-2343-0/+675
|
* use syscall_arg_t type for syscall prototypes in pthread coderofl0r2014-02-222-3/+8
|
* internal/syscall.h: add syscall_arg_t macrorofl0r2014-02-221-6/+11
| | | | | | | some 32-on-64 archs require that the actual syscall args be long long. in that case syscall_arch.h can define syscall_arg_t to whatever it needs and syscall.h picks it up. all other archs just use long as usual.
* internal/syscall.h: use a macro for the syscall args castsrofl0r2014-02-221-13/+17
| | | | | | | this allows syscall_arch.h to define the macro __scc if special casting is needed, as is the case for x32, where the actual syscall arguments are 64bit, but, in case of pointers, would get sign-extended and thus become invalid.
* add fallback emulation for accept4 on old kernelsRich Felker2014-02-211-1/+12
| | | | | | | | | | | | the other atomic FD_CLOEXEC interfaces (dup3, pipe2, socket) already had such emulation in place. the justification for doing the emulation here is the same as for the other functions: it allows applications to simply use accept4 rather than having to have their own fallback code for ENOSYS/EINVAL (which one you get is arch-specific!) and there is no reasonable way an application could benefit from knowing the operation is emulated/non-atomic since there is no workaround at the application level for non-atomicity (that is the whole reason these interfaces were added).
* add ipv6 and icmpv6 to getprotoent-family functionsRich Felker2014-02-131-1/+3
| | | | based on patch by orc.
* fix typo in table for getprotoent that caused out-of-bound readsRich Felker2014-02-131-1/+1
| | | | | | | | this was unlikely to lead to any crash or dangerous behavior, but caused adjacent string constants to be treated as part of the protocols table, possibly returning nonsensical results for unknown protocol names/numbers or when getprotoent was called in a loop to enumerate all protocols.
* make posix_spawn accept null pid pointer argumentsRich Felker2014-02-121-1/+1
| | | | this is a requirement in the specification that was overlooked.
* clone: make clone a wrapper around __cloneBobby Bingham2014-02-096-18/+22
| | | | | | | | | | | | The architecture-specific assembly versions of clone did not set errno on failure, which is inconsistent with glibc. __clone still returns the error via its return value, and clone is now a wrapper that sets errno as needed. The public clone has also been moved to src/linux, as it's not directly related to the pthreads API. __clone is called by pthread_create, which does not report errors via errno. Though not strictly necessary, it's nice to avoid clobbering errno here.
* fix fesetenv(FE_DFL_ENV) on x86_64 (see previous commit)Szabolcs Nagy2014-02-091-1/+1
|
* fix fesetenv(FE_DFL_ENV) on i386Szabolcs Nagy2014-02-091-1/+1
| | | | | | | | | | | the default fenv was not set up properly, in particular the tag word that indicates the contents of the x87 registers was set to 0 (used) instead of 0xffff (empty) this could cause random crashes after setting the default fenv because it corrupted the fpu stack and then any float computation gives NaN result breaking the program logic (usually after a float to integer conversion).
* in fdopen, avoid setting O_APPEND flag if it's already setRich Felker2014-02-071-1/+2
| | | | | | | this saves a syscall in the case where the underlying open already took place with O_APPEND, which is common because fopen with append modes sets O_APPEND at the time of open before passing the file descriptor to __fdopen.
* fix ftello result for append streams with unflushed outputRich Felker2014-02-073-1/+5
| | | | | | | | | | | | | | | | | | | | | | when there is unflushed output, ftello (and ftell) compute the logical stream position as the underlying file descriptor's offset plus an adjustment for the amount of buffered data. however, this can give the wrong result for append-mode streams where the unflushed writes should adjust the logical position to be at the end of the file, as if a seek to end-of-file takes place before the write. the solution turns out to be a simple trick: when ftello (indirectly) calls lseek to determine the current file offset, use SEEK_END instead of SEEK_CUR if the stream is append-mode and there's unwritten buffered data. the ISO C rules regarding switching between reading and writing for a stream opened in an update mode, along with the POSIX rules regarding switching "active handles", conveniently leave undefined the hypothetical usage cases where this fix might lead to observably incorrect offsets. the bug being fixed was discovered via the test case for glibc issue
* add legacy functions setkey() and encrypt()Timo Teräs2014-02-052-6/+66
|
* fix nftw FTW_MOUNT flagRich Felker2014-02-011-2/+1
| | | | | the incorrect check for crossing device boundaries was preventing nftw from traversing anything except the initially provided pathname.
* fix an overflow in wcsxfrm when n==0Szabolcs Nagy2014-01-231-2/+4
| | | | posix allows zero length destination
* fix crash in dynamic linker when certain copy relocations are unsatisfiedRich Felker2014-01-211-1/+2
| | | | | | | | | | | | | | | | | | | | | STB_WEAK is only a weak reference for undefined symbols (those with a section of SHN_UNDEF). otherwise, it's a weak definition. normally this distinction would not matter, since a relocation referencing a symbol that also provides a definition (not SHN_UNDEF) will always succeed in finding the referenced symbol itself. however, in the case of copy relocations, the referenced symbol itself is ignored in order to search for another symbol to copy from, and thus it's possible that no definition is found. in this case, if the symbol being resolved happened to be a weak definition, it was misinterpreted as a weak reference, suppressing the error path and causing a crash when the copy relocation was performed with a null source pointer passed to memcpy. there are almost certainly still situations in which invalid combinations of symbol and relocation types can cause the dynamic linker to crash (this is pretty much inevitable), but the intent is that crashes not be possible for symbol/relocation tables produced by a valid linker.
* fix initstate to make the state buffer usable in setstateSzabolcs Nagy2014-01-211-12/+2
| | | | | | | | | | | setstate could use the results of previous initstate or setstate calls (they return the old state buffer), but the documentation requires that an initialized state buffer should be possible to use in setstate immediately, which means that initstate should save the generator parameters in it. I also removed the copyright notice since it is present in the copyright file.
* fix inadvertent use of struct in place of union for semunRich Felker2014-01-081-3/+3
|
* add __isoc99_vfscanf weak alias to vfscanfSzabolcs Nagy2014-01-081-0/+2
| | | | | this glibc abi compatibility function was missed when the scanf aliases were added.
* math: add drem and dremf weak aliases to i386 remainder asmSzabolcs Nagy2014-01-082-0/+6
| | | | | weak_alias was only in the c code, so drem was missing on platforms where remainder is implemented in asm.
* fix type of semctl variadic argumentRich Felker2014-01-081-4/+10
| | | | | | | | | | | | | | | | | | per POSIX, the variadic argument has type union semun, which may contain a pointer or int; the type read depends on the command being issued. this allows the userspace part of the implementation to be type-correct without requiring special-casing for different commands. the kernel always expects to receive the argument interpreted as unsigned long (or equivalently, a pointer), and does its own handling of extracting the int portion from the representation, as needed. this change fixes two possible issues: most immediately, reading the argument as a (signed) long and passing it to the syscall would perform incorrect sign-extension of pointers on the upcoming x32 target. the other possible issue is that some archs may use different (user-space) argument-passing convention for unions, preventing va_arg from correctly obtaining the argument when the type long (or even unsigned long or void *) is passed to it.
* in fcntl, avoid passing pointer arguments to syscalls as longsRich Felker2014-01-081-3/+12
| | | | | | | | | | | | | really, fcntl should be changed to use the correct type corresponding to cmd when calling va_arg, and to carry the correct type through until making the syscall. however, this greatly increases binary size and does not seem to offer any benefits except formal correctness, so I'm holding off on that change for now. the minimal changes made in this patch are in preparation for addition of the x32 port, where the syscall macros need to know whether their arguments are pointers or integers in order to properly pass them to the 64-bit kernel.
* fix const-correctness of argument to stimeRich Felker2014-01-071-1/+1
| | | | | | | it's unclear what the historical signature for this function was, but semantically, the argument should be a pointer to const, and this is what glibc uses. correct programs should not be using this function anyway, so it's unlikely to matter.
* fix signedness of pgoff argument to remap_file_pagesRich Felker2014-01-071-1/+1
| | | | | both the kernel and glibc agree that this argument is unsigned; the incorrect type ssize_t came from erroneous man pages.
* fix const-correctness in sigandset/sigorset argumentsRich Felker2014-01-072-2/+2
| | | | | | this change is consistent with the corresponding glibc functions and is semantically const-correct. the incorrect argument types without const seem to have been taken from erroneous man pages.
* fix incorrect type for wd argument of inotify_rm_watchRich Felker2014-01-071-1/+1
| | | | | | this was wrong since the original commit adding inotify, and I don't see any explanation for it. not even the man pages have it wrong. it was most likely a copy-and-paste error.
* fix argument types for legacy function inet_makeaddrRich Felker2014-01-061-2/+1
| | | | | | the type int was taken from seemingly erroneous man pages. glibc uses in_addr_t (uint32_t), and semantically, the arguments should be unsigned.
* eliminate explicit (long) casts when making syscallsRich Felker2014-01-065-5/+5
| | | | | | | | this practice came from very early, before internal/syscall.h defined macros that could accept pointer arguments directly and handle them correctly. aside from being ugly and unnecessary, it looks like it will be problematic when we add support for 32-bit ABIs on archs where registers (and syscall arguments) are 64-bit, e.g. x32 and mips n32.
* const-qualify the address argument to dladdrRich Felker2014-01-062-4/+4
| | | | | | | this agrees with implementation practice on glibc and BSD systems, and is the const-correct way to do things; it eliminates warnings from passing pointers to const. the prototype without const came from seemingly erroneous man pages.
* add some missing LFS64 aliases for fadvise/fallocate functionsRich Felker2014-01-063-0/+10
|
* fanotify.c: fix typo in header inclusionrofl0r2014-01-031-1/+1
| | | | | | the header is included only as a guard to check that the declaration and definition match, so the typo didn't cause any breakage aside from omitting this check.
* disable the brk functionRich Felker2014-01-021-1/+2
| | | | | | the reasons are the same as for sbrk. unlike sbrk, there is no safe usage because brk does not return any useful information, so it should just fail unconditionally.
* disable sbrk for all values of increment except 0Rich Felker2014-01-021-3/+3
| | | | | | | | | | | | | | | use of sbrk is never safe; it conflicts with malloc, and malloc may be used internally by the implementation basically anywhere. prior to this change, applications attempting to use sbrk to do their own heap management simply caused untrackable memory corruption; now, they will fail with ENOMEM allowing the errors to be fixed. sbrk(0) is still permitted as a way to get the current brk; some misguided applications use this as a measurement of their memory usage or for other related purposes, and such usage is harmless. eventually sbrk may be re-added if/when malloc is changed to avoid using the brk by using mmap for all allocations.
* add fanotify syscall wrapper and headerrofl0r2014-01-021-0/+14
|
* implement legacy function herrorRich Felker2013-12-201-0/+8
| | | | based on patch by Timo Teräs; greatly simplified to use fprintf.
* add sys/quota.h and quotactl syscall wrapperRich Felker2013-12-201-0/+7
| | | | based on patch by Timo Teräs.
* fix failure of fchmod, fstat, fchdir, and fchown to produce EBADFRich Felker2013-12-194-4/+12
| | | | | | | | | | | | | | | | | | | the workaround/fallback code for supporting O_PATH file descriptors when the kernel lacks support for performing these operations on them caused EBADF to get replaced by ENOENT (due to missing entry in /proc/self/fd). this is unlikely to affect real-world code (calls that might yield EBADF are generally unsafe, especially in library code) but it was breaking some test cases. the fix I've applied is something of a tradeoff: it adds one syscall to these operations on kernels where the workaround is needed. the alternative would be to catch ENOENT from the /proc lookup and translate it to EBADF, but I want to avoid doing that in the interest of not touching/depending on /proc at all in these functions as long as the kernel correctly supports the operations. this is following the general principle of isolating hacks to code paths that are taken on broken systems, and keeping the code for correct systems completely hack-free.
* fix hangs in localtime for near-overflowing time_t values on 64-bit archsRich Felker2013-12-191-0/+6
|
* fix dynamic linker entry point for microblazeRich Felker2013-12-141-3/+4
| | | | | | | | the ABI allows the callee to clobber stack slots that correspond to arguments passed in registers, so the caller must adjust the stack pointer to reserve space appropriately. prior to this fix, the argv array was possibly clobbered by dynamic linker code before passing control to the main program.
* optimize get_current_dir_name to reduce stack bloatRich Felker2013-12-131-3/+1
| | | | | | | | our getcwd already (as an extension) supports allocation of a buffer when the buffer argument is a null pointer, so there's no need to duplicate the allocation logic in this wrapper function. duplicating it is actually harmful in that it doubles the stack usage from PATH_MAX to 2*PATH_MAX.
* use 0 instead of NULL for null pointer constantsRich Felker2013-12-137-15/+8
| | | | and thereby remove otherwise-unnecessary inclusion of stddef.h
* include cleanups: remove unused headers and add feature test macrosSzabolcs Nagy2013-12-12157-207/+68
|
* remove an unnecessary check in inet_ptonSzabolcs Nagy2013-12-121-2/+1
| | | | | at most 4 hexadecimal digits are processed in one field so the value cannot overflow. the netdb.h header was not used.
* math: define _GNU_SOURCE when implementing non-standard math functionsSzabolcs Nagy2013-12-126-0/+6
| | | | | this makes the prototypes in math.h are visible so they are checked agaist the function definitions
* add posix_close, accepted for inclusion in the next issue of POSIXRich Felker2013-12-061-0/+6
| | | | | this is purely a wrapper for close since Linux does not support EINTR semantics for the close syscall.
* implement FNM_LEADING_DIR extension flag in fnmatchRich Felker2013-12-021-2/+9
| | | | | | | | | | | | | | | | previously this flag was defined and accepted as a no-op, possibly breaking some software that uses it. given the choice to remove the definition and possibly break applications that were already working, or simply implement the feature, the latter turned out to be easy enough to make the decision easy. in the case where the FNM_PATHNAME flag is also set, this implementation is clean and essentially optimal. otherwise, it's an inefficient "brute force" implementation. at some point, when cleaning up and refactoring this code, I may add a more direct code path for handling FNM_LEADING_DIR in the non-FNM_PATHNAME case, but at this point my main interest is avoiding introducing new bugs in the code that implements the standard fnmatch features specified by POSIX.
* add infrastructure to record and report the version of libc.soRich Felker2013-12-012-2/+19
| | | | | | | this is still experimental and subject to change. for git checkouts, an attempt is made to record the exact revision to aid in bug reports and debugging. no version information is recorded in the static libc.a or binaries it's linked into.
* fix fnmatch corner cases related to escapingRich Felker2013-12-011-4/+4
| | | | | | the FNM_PATHNAME logic for advancing by /-delimited components was incorrect when the / character was escaped (i.e. \/), and a final \ at the end of pattern was not handled correctly.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-05 13:24:23 +0000